From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4 2/3] tools: logo: add static and unused to bmp arrays
Date: Thu, 20 Oct 2011 08:42:01 -0400 [thread overview]
Message-ID: <201110200842.02506.vapier@gentoo.org> (raw)
In-Reply-To: <1319089126-7358-3-git-send-email-clchiou@chromium.org>
On Thursday 20 October 2011 01:38:45 Che-Liang Chiou wrote:
> The generated header bmp_logo.h is useful even outside common/lcd.c for
> the logo dimension. However, the problem is, the generated bmp_logo.h
> cannot be included multiple times because bmp_logo_palette[] and
> bmp_logo_bitmap[] are defined in the bmp_logo.h.
>
> We may remedy this by adding
> static __attribute__((unused))
> to the array definitions so that bmp_logo.h can be included multiple
> times, and these arrays is used in only one inclusion (lcd.c).
i'm not sure this is the right way to go. what if we split bmp_logo.h instead
into bmp_logo_data.h (which has the array contents) and bmp_log.h (which has
the defines and externs for the data arrays) ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111020/cbf75b44/attachment.pgp
next prev parent reply other threads:[~2011-10-20 12:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 8:16 [U-Boot] [PATCH 0/2] api: export LCD and video to external apps Che-Liang Chiou
2011-10-04 8:16 ` [U-Boot] [PATCH 1/2] lcd: video: add clear and draw bitmap declaration Che-Liang Chiou
2011-10-06 18:34 ` Wolfgang Denk
2011-10-04 8:16 ` [U-Boot] [PATCH 2/2] api: export LCD and video to external apps Che-Liang Chiou
2011-10-06 18:33 ` Wolfgang Denk
2011-10-07 8:32 ` Che-liang Chiou
2011-10-07 9:05 ` Wolfgang Denk
2011-10-07 9:45 ` Che-liang Chiou
2011-10-09 20:00 ` Wolfgang Denk
2011-10-07 8:28 ` [U-Boot] [PATCH V2 0/2] " Che-Liang Chiou
2011-10-07 8:28 ` [U-Boot] [PATCH V2 1/2] lcd: video: add clear and draw bitmap declaration Che-Liang Chiou
2011-10-07 8:28 ` [U-Boot] [PATCH V2 2/2] api: export LCD and video to external apps Che-Liang Chiou
2011-10-17 21:13 ` Anatolij Gustschin
2011-10-18 6:12 ` Che-liang Chiou
2011-10-18 7:17 ` Anatolij Gustschin
2011-10-18 8:24 ` Che-liang Chiou
2011-10-18 9:15 ` [U-Boot] [PATCH V3 0/4] " Che-Liang Chiou
2011-10-18 9:15 ` [U-Boot] [PATCH V3 1/4] lcd: video: add clear and draw bitmap declaration Che-Liang Chiou
2011-10-18 9:15 ` [U-Boot] [PATCH V3 2/4] tools: logo: add static and unused to bmp arrays Che-Liang Chiou
2011-10-18 9:15 ` [U-Boot] [PATCH V3 3/4] video: add access to GraphicDevice struct Che-Liang Chiou
2011-10-19 8:27 ` Anatolij Gustschin
2011-10-18 9:15 ` [U-Boot] [PATCH V3 4/4] api: export LCD and video to external apps Che-Liang Chiou
2011-10-19 8:56 ` Anatolij Gustschin
2011-10-20 5:41 ` Che-liang Chiou
2011-10-20 5:38 ` [U-Boot] [PATCH V4 0/3] " Che-Liang Chiou
2011-10-20 5:38 ` [U-Boot] [PATCH V4 1/3] lcd: add clear and draw bitmap declaration Che-Liang Chiou
2011-10-20 12:38 ` Mike Frysinger
2011-10-20 5:38 ` [U-Boot] [PATCH V4 2/3] tools: logo: add static and unused to bmp arrays Che-Liang Chiou
2011-10-20 12:42 ` Mike Frysinger [this message]
2011-10-20 18:43 ` Wolfgang Denk
2011-10-20 5:38 ` [U-Boot] [PATCH V4 3/3] api: export LCD device to external apps Che-Liang Chiou
2011-10-20 13:25 ` Mike Frysinger
2011-10-21 9:04 ` [U-Boot] [PATCH V5 0/4] " Che-Liang Chiou
2011-10-21 9:04 ` [U-Boot] [PATCH V5 1/4] lcd: add clear and draw bitmap declaration Che-Liang Chiou
2011-10-30 15:16 ` Mike Frysinger
2011-10-30 18:21 ` [U-Boot] [PATCH v6 " Anatolij Gustschin
2011-11-10 22:31 ` Anatolij Gustschin
2011-10-21 9:04 ` [U-Boot] [PATCH V5 2/4] tools: logo: split bmp arrays from bmp_logo.h Che-Liang Chiou
2011-10-30 15:24 ` Mike Frysinger
2011-10-30 18:24 ` [U-Boot] [PATCH v6 " Anatolij Gustschin
2011-11-10 22:33 ` Anatolij Gustschin
2011-10-21 9:04 ` [U-Boot] [PATCH V5 3/4] font: split font data from video_font.h Che-Liang Chiou
2011-10-30 15:36 ` Mike Frysinger
2011-10-30 18:33 ` Anatolij Gustschin
2011-10-31 2:23 ` Che-liang Chiou
2011-11-10 22:36 ` Anatolij Gustschin
2011-10-21 9:04 ` [U-Boot] [PATCH V5 4/4] api: export LCD device to external apps Che-Liang Chiou
2011-11-10 22:41 ` Anatolij Gustschin
2011-10-21 9:07 ` [U-Boot] [PATCH V5 1/4] lcd: add clear and draw bitmap declaration Che-Liang Chiou
2011-10-30 15:37 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110200842.02506.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox