From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Thu, 20 Oct 2011 08:42:01 -0400 Subject: [U-Boot] [PATCH V4 2/3] tools: logo: add static and unused to bmp arrays In-Reply-To: <1319089126-7358-3-git-send-email-clchiou@chromium.org> References: <1319089126-7358-1-git-send-email-clchiou@chromium.org> <1319089126-7358-3-git-send-email-clchiou@chromium.org> Message-ID: <201110200842.02506.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 20 October 2011 01:38:45 Che-Liang Chiou wrote: > The generated header bmp_logo.h is useful even outside common/lcd.c for > the logo dimension. However, the problem is, the generated bmp_logo.h > cannot be included multiple times because bmp_logo_palette[] and > bmp_logo_bitmap[] are defined in the bmp_logo.h. > > We may remedy this by adding > static __attribute__((unused)) > to the array definitions so that bmp_logo.h can be included multiple > times, and these arrays is used in only one inclusion (lcd.c). i'm not sure this is the right way to go. what if we split bmp_logo.h instead into bmp_logo_data.h (which has the array contents) and bmp_log.h (which has the defines and externs for the data arrays) ? -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20111020/cbf75b44/attachment.pgp