From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Allow the "reset" command to be omitted with CONFIG_CMD_RESET
Date: Thu, 20 Oct 2011 15:53:50 -0400 [thread overview]
Message-ID: <201110201553.50639.vapier@gentoo.org> (raw)
In-Reply-To: <1319137550-6503-1-git-send-email-Kyle.D.Moffett@boeing.com>
On Thursday 20 October 2011 15:05:50 Kyle Moffett wrote:
> This new #define is set by default in config_cmd_defaults.h, and
> config_cmd_all.h, but this allows boards to conditionally omit the
> "reset" command if necessary.
ignoring the related issues as i'm sure Wolfgang will chime in ...
> --- a/common/cmd_boot.c
> +++ b/common/cmd_boot.c
> @@ -71,8 +71,10 @@ U_BOOT_CMD(
>
> #endif
>
> +#ifdef CONFIG_CMD_RESET
> U_BOOT_CMD(
> reset, 1, 0, do_reset,
> "Perform RESET of the CPU",
> ""
> );
> +#endif
would be a good time to split this into a dedicated common/cmd_reset.c
> --- a/include/config_cmd_all.h
> +++ b/include/config_cmd_all.h
>
> --- a/include/config_cmd_defaults.h
> +++ b/include/config_cmd_defaults.h
updating these files is not sufficient and will break boards. drop the hunks to
these files and update include/config_defaults.h instead.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111020/33e75fe2/attachment.pgp
next prev parent reply other threads:[~2011-10-20 19:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 19:05 [U-Boot] [PATCH] Allow the "reset" command to be omitted with CONFIG_CMD_RESET Kyle Moffett
2011-10-20 19:53 ` Mike Frysinger [this message]
2011-10-20 20:10 ` Moffett, Kyle D
2011-10-20 20:22 ` Mike Frysinger
-- strict thread matches above, loose matches on Subject: below --
2011-12-16 3:32 Kyle Moffett
2011-12-16 5:05 ` Mike Frysinger
2011-12-16 18:49 ` Moffett, Kyle D
2011-12-16 19:30 ` Mike Frysinger
2011-12-16 20:42 ` Moffett, Kyle D
2011-12-16 22:07 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110201553.50639.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox