From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/8] tegra2: spi: Support SPI / UART switch
Date: Thu, 20 Oct 2011 16:08:03 -0400 [thread overview]
Message-ID: <201110201608.04557.vapier@gentoo.org> (raw)
In-Reply-To: <1319137409-4132-8-git-send-email-sjg@chromium.org>
On Thursday 20 October 2011 15:03:28 Simon Glass wrote:
> --- a/drivers/spi/tegra2_spi.c
> +++ b/drivers/spi/tegra2_spi.c
>
> +#include <ns16550.h> /* for NS16550_drain and NS16550_clear */
except you don't use those funcs in this file ... so this include shouldn't be
here ?
> +#include "uart-spi-fix.h"
this file isn't in drivers/spi/, so you shouldn't be using "".
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111020/8af8dc2c/attachment.pgp
next prev parent reply other threads:[~2011-10-20 20:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 19:03 [U-Boot] [PATCH 0/8] tegra2: Implement SPI flash and saved environment Simon Glass
2011-10-20 19:03 ` [U-Boot] [PATCH 1/8] tegra2: Tidy UART selection Simon Glass
2011-10-20 19:03 ` [U-Boot] [PATCH 2/8] tegra2: Add UARTB support Simon Glass
2011-10-20 19:03 ` [U-Boot] [PATCH 3/8] tegra2: spi: Add SPI driver for SPIFLASH on Seaboard Simon Glass
2011-10-20 20:03 ` Mike Frysinger
2011-10-20 23:02 ` Simon Glass
2011-10-20 19:03 ` [U-Boot] [PATCH 4/8] tegra2: config: Enable SPI flash " Simon Glass
2011-10-20 19:03 ` [U-Boot] [PATCH 5/8] tegra2: Enable SPI environment " Simon Glass
2011-10-20 19:31 ` Tom Warren
2011-10-20 19:58 ` Simon Glass
2011-10-20 20:49 ` Tom Warren
2011-10-20 19:03 ` [U-Boot] [PATCH 6/8] tegra2: Implement SPI / UART GPIO switch Simon Glass
2011-10-20 20:06 ` Mike Frysinger
2011-10-20 20:08 ` Mike Frysinger
2011-10-20 19:03 ` [U-Boot] [PATCH 7/8] tegra2: spi: Support SPI / UART switch Simon Glass
2011-10-20 20:08 ` Mike Frysinger [this message]
2011-10-20 19:03 ` [U-Boot] [PATCH 8/8] tegra2: Create SPI/UART switch code Simon Glass
2011-10-20 20:09 ` Mike Frysinger
2011-10-20 20:23 ` Simon Glass
2011-10-20 20:34 ` Mike Frysinger
2011-10-20 20:44 ` Simon Glass
2011-10-20 20:50 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110201608.04557.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox