From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Date: Thu, 20 Oct 2011 16:08:55 -0400
Subject: [U-Boot] [PATCH 6/8] tegra2: Implement SPI / UART GPIO switch
In-Reply-To: <1319137409-4132-7-git-send-email-sjg@chromium.org>
References: <1319137409-4132-1-git-send-email-sjg@chromium.org>
	<1319137409-4132-7-git-send-email-sjg@chromium.org>
Message-ID: <201110201608.56005.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thursday 20 October 2011 15:03:27 Simon Glass wrote:
> +void uart_enable(NS16550_t regs);
> +void spi_enable(void);

also, you're not really enabling these devices, you're switching the pinmux.  
so perhaps a better name would be "pinmux_select_uart()" ?  or something 
similar ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111020/39273974/attachment.pgp