From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Allow the "reset" command to be omitted with CONFIG_CMD_RESET
Date: Thu, 20 Oct 2011 16:22:33 -0400 [thread overview]
Message-ID: <201110201622.34115.vapier@gentoo.org> (raw)
In-Reply-To: <E1B214DA-206B-48C1-9A54-C5A7FD5D649A@boeing.com>
On Thursday 20 October 2011 16:10:10 Moffett, Kyle D wrote:
> On Oct 20, 2011, at 15:53, Mike Frysinger wrote:
> > On Thursday 20 October 2011 15:05:50 Kyle Moffett wrote:
> >> --- a/common/cmd_boot.c
> >> +++ b/common/cmd_boot.c
> >> @@ -71,8 +71,10 @@ U_BOOT_CMD(
> >>
> >> #endif
> >>
> >> +#ifdef CONFIG_CMD_RESET
> >> U_BOOT_CMD(
> >>
> >> reset, 1, 0, do_reset,
> >> "Perform RESET of the CPU",
> >> ""
> >>
> >> );
> >> +#endif
> >
> > would be a good time to split this into a dedicated common/cmd_reset.c
>
> Is it really worth a separate file for just 7 lines of code?
>
> The "do_reset" function itself is defined in the architecture-specific
> code that implements it (EG: arch/powerpc/cpu/mpc85xx/cpu.c), so there
> is nothing else generic about the command.
we can also then fix cmd_boot.c to only build when CONFIG_CMD_GO is enabled
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111020/0973fd81/attachment.pgp
next prev parent reply other threads:[~2011-10-20 20:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 19:05 [U-Boot] [PATCH] Allow the "reset" command to be omitted with CONFIG_CMD_RESET Kyle Moffett
2011-10-20 19:53 ` Mike Frysinger
2011-10-20 20:10 ` Moffett, Kyle D
2011-10-20 20:22 ` Mike Frysinger [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-16 3:32 Kyle Moffett
2011-12-16 5:05 ` Mike Frysinger
2011-12-16 18:49 ` Moffett, Kyle D
2011-12-16 19:30 ` Mike Frysinger
2011-12-16 20:42 ` Moffett, Kyle D
2011-12-16 22:07 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110201622.34115.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox