From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mii: miiphy register address width change
Date: Thu, 20 Oct 2011 18:42:18 -0400 [thread overview]
Message-ID: <201110201842.19466.vapier@gentoo.org> (raw)
In-Reply-To: <CAKWjMd4r+O7LB_xwxwU__KhEJaHsbQtH5S-ye-jDmg2n9fHb5Q@mail.gmail.com>
On Thursday 20 October 2011 17:45:33 Andy Fleming wrote:
> On Thu, Oct 20, 2011 at 8:58 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Thursday 20 October 2011 09:55:34 Kumar Gala wrote:
> >> On Oct 20, 2011, at 8:26 AM, Mike Frysinger wrote:
> >> > On Thursday 20 October 2011 06:34:33 Kumar Nath, Chandan wrote:
> >> >> This patch was acked on September 21, but in latest code base I could
> >> >> not find this patch. Is there anything left which I need to take care
> >> >> in my patch. If so, please let me know so that this can be picked up.
> >> >
> >> > i don't merge net patches. wolfgang does. i don't think there's
> >> > anything left for you to do.
> >>
> >> I think this breaks 10g support. I'm pretty sure Andy made the data
> >> type a short for a reason.
> >
> > the data type in mainline is 8bits (char). Chandan is fixing it to be
> > 16bits (short). if 10g breaks with a short, that sounds like a bug in
> > the 10g code we should figure out + fix. Linux is using a short just
> > fine afaict.
>
> Actually, there's some confusion, here. The function being updated by
> this patch isn't part of phylib. It's part of the legacy miiphy code.
> I don't think there's any reason to update it. If you are writing a
> new driver with 10G support (which would, admittedly, require a 16-bit
> register argument), then don't use miiphy_register. Call
> mdio_register, and register proper phylib support. The mii command
> isn't capable of dealing with Clause-45 MDIO transactions, anyway (no
> devad)
so the patch is correct, but we don't want to merge it because we don't want
to encourage the old miiphy interface ? and leaving it broken forces people
to migrate to the new phy layer ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111020/42c67471/attachment.pgp
next prev parent reply other threads:[~2011-10-20 22:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 11:10 [U-Boot] [PATCH] mii: miiphy register address width change Chandan Nath
2011-09-21 14:21 ` Mike Frysinger
2011-10-20 10:34 ` Kumar
2011-10-20 13:26 ` Mike Frysinger
2011-10-20 13:55 ` Kumar Gala
2011-10-20 13:58 ` Mike Frysinger
2011-10-20 14:03 ` Kumar
2011-10-20 18:29 ` Kumar Gala
2011-10-20 21:45 ` Andy Fleming
2011-10-20 22:42 ` Mike Frysinger [this message]
2011-10-20 22:53 ` Andy Fleming
2011-10-21 5:39 ` Kumar
2011-10-21 10:03 ` Wolfgang Denk
2011-10-30 15:38 ` Mike Frysinger
2011-12-06 20:18 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110201842.19466.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox