From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 REPOST 2/3] image: Implement IH_TYPE_KERNEL_REL
Date: Thu, 20 Oct 2011 20:56:58 +0200 [thread overview]
Message-ID: <20111020185658.DA2D314094B3@gemini.denx.de> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF173D51C136@HQMAIL01.nvidia.com>
Dear Stephen Warren,
In message <74CDBE0F657A3D45AFBB94109FB122FF173D51C136@HQMAIL01.nvidia.com> you wrote:
>
> > > > Please give me a bit more context - how much is "a few 10s of bytes",
> > > > and which exact parts of the code are we talkign about?
> > >
> > > How much? However much adding an extra value into an if check compiles to.
> >
> > As much as needed so I can see what you mean without having to go
> > through the whole thread.
>
> 'How much' above was a quote from where you were asking 'how much is "a
> few bytes"', not 'how much' explanation you want.
You wrote "a few 10s of bytes" - this is obviously more than "adding
an extra value into an if check compiles to", so I guess you ar enot
talking about doing this just once, but more frequently. So please be
precise.
> OK then, please just disregard the question and review the patch itself
> as I posted it. Just by reviewing and hopefully accepting the patch,
> you'll see the number of ifdefs and whether they're appropriate.
Please provide this information in advance, before I start looking at
the patch.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How many NASA managers does it take to screw in a lightbulb? "That's
a known problem... don't worry about it."
next prev parent reply other threads:[~2011-10-20 18:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 21:11 [U-Boot] [PATCH v2 REPOST 1/3] [COSMETIC] checkpatch whitespace cleanups Stephen Warren
2011-10-18 21:11 ` [U-Boot] [PATCH v2 REPOST 2/3] image: Implement IH_TYPE_KERNEL_REL Stephen Warren
2011-10-19 0:56 ` Simon Glass
2011-10-19 15:55 ` Stephen Warren
2011-10-19 20:00 ` Wolfgang Denk
2011-10-19 21:58 ` Stephen Warren
2011-10-20 14:04 ` Wolfgang Denk
2011-10-20 15:43 ` Stephen Warren
2011-10-20 18:56 ` Wolfgang Denk [this message]
2011-10-20 19:03 ` Stephen Warren
2011-10-20 19:09 ` Simon Glass
2011-10-20 19:39 ` Wolfgang Denk
2011-10-20 19:52 ` Stephen Warren
2011-10-20 21:46 ` Wolfgang Denk
2011-10-20 21:54 ` Stephen Warren
2011-10-20 19:37 ` Wolfgang Denk
2011-10-20 22:29 ` Simon Glass
2011-10-18 21:11 ` [U-Boot] [PATCH v2 REPOST 3/3] tegra2: Enable CONFIG_SYS_RELATIVE_IMAGES Stephen Warren
2011-10-19 1:03 ` Simon Glass
2011-10-19 15:24 ` Stephen Warren
2011-10-20 20:27 ` Simon Glass
2011-10-20 20:47 ` Stephen Warren
2011-10-20 22:27 ` Simon Glass
2011-10-19 0:01 ` [U-Boot] [PATCH v2 REPOST 1/3] [COSMETIC] checkpatch whitespace cleanups Simon Glass
2011-10-19 1:01 ` Simon Glass
2011-10-21 23:13 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111020185658.DA2D314094B3@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox