From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Thu, 20 Oct 2011 20:56:58 +0200 Subject: [U-Boot] [PATCH v2 REPOST 2/3] image: Implement IH_TYPE_KERNEL_REL In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF173D51C136@HQMAIL01.nvidia.com> References: <1318972311-673-1-git-send-email-swarren@nvidia.com> <1318972311-673-2-git-send-email-swarren@nvidia.com> <74CDBE0F657A3D45AFBB94109FB122FF173D51BE0F@HQMAIL01.nvidia.com> <20111019200051.AAFEA140ABD3@gemini.denx.de> <74CDBE0F657A3D45AFBB94109FB122FF173D51BFE4@HQMAIL01.nvidia.com> <20111020140404.5241215794DB@gemini.denx.de> <74CDBE0F657A3D45AFBB94109FB122FF173D51C136@HQMAIL01.nvidia.com> Message-ID: <20111020185658.DA2D314094B3@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stephen Warren, In message <74CDBE0F657A3D45AFBB94109FB122FF173D51C136@HQMAIL01.nvidia.com> you wrote: > > > > > Please give me a bit more context - how much is "a few 10s of bytes", > > > > and which exact parts of the code are we talkign about? > > > > > > How much? However much adding an extra value into an if check compiles to. > > > > As much as needed so I can see what you mean without having to go > > through the whole thread. > > 'How much' above was a quote from where you were asking 'how much is "a > few bytes"', not 'how much' explanation you want. You wrote "a few 10s of bytes" - this is obviously more than "adding an extra value into an if check compiles to", so I guess you ar enot talking about doing this just once, but more frequently. So please be precise. > OK then, please just disregard the question and review the patch itself > as I posted it. Just by reviewing and hopefully accepting the patch, > you'll see the number of ifdefs and whether they're appropriate. Please provide this information in advance, before I start looking at the patch. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de How many NASA managers does it take to screw in a lightbulb? "That's a known problem... don't worry about it."