From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] cmdline: Add linux command line munging tools
Date: Thu, 20 Oct 2011 21:03:42 +0200 [thread overview]
Message-ID: <20111020190342.374E214094B3@gemini.denx.de> (raw)
In-Reply-To: <CAD=FV=WEk1To=hyOTLBC+htq=7hxrTqtyckajJyLByqs3DBFYA@mail.gmail.com>
Dear Doug Anderson,
In message <CAD=FV=WEk1To=hyOTLBC+htq=7hxrTqtyckajJyLByqs3DBFYA@mail.gmail.com> you wrote:
>
> I'm happy to explain. :) In our setup, the Linux command line is
> constructed (in part) by reading from the disk. When we load the kernel, we
> also load the kernel command line. It is convenient for us if this kernel
> command line on disk continues to have things like "console=/dev/ttyS0" and
> "earlyprintk" in it so that we can swap between release (no console) and
> development (with console) by just tweaking a settings in u-boot.
>
> Certainly we could change our setup, but the prior existence
> of fixup_silent_linux() indicated that this might be a common way to do
> things.
Please check where this is actually used, and how. It serves a very
special purpose, and by todays level of reviews I seriously doubt such
code would be accepted any more.
Yes, please change your setup. Just because you are doing things your
(highly unefficient) way does not mean I'm going to accept such code
for mainline.
> In the case of Chromium OS, we also do some additional programmatic munging
> of the command line for verified boot purposes, but since that is not
> upstream it's not really a good argument for making the more general
> function.
May I ask why you don;t use the powerful capabilities of incrementally
building the command line from environment variable settings?
[These can also be read from disk.]
> In any case, I already have the more direct (and less generalized) version
> of fixup_silent_linux() written and will send out a patch with just that
> shortly.
Please consider it NAKed.
> Based on your comments, I'll assume that you're not interested in the more
> general command line munging tools and will abandon them for now until there
> is a clear need for them.
"Not interested" is an understatement. I consider them a highly
unefficient and conceptually broken approach.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A quarrel is quickly settled when deserted by one party; there is no
battle unless there be two. - Seneca
next prev parent reply other threads:[~2011-10-20 19:03 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 22:30 [U-Boot] [PATCH 0/4] Fix fixup_silent_linux() buffer overrun Doug Anderson
2011-10-19 22:30 ` [U-Boot] [PATCH 1/4] cmdline: Add linux command line munging tools Doug Anderson
2011-10-19 22:46 ` Mike Frysinger
2011-10-20 1:23 ` Doug Anderson
2011-10-19 22:52 ` Mike Frysinger
2011-10-20 1:07 ` Doug Anderson
2011-10-20 1:37 ` Mike Frysinger
2011-10-20 14:36 ` Wolfgang Denk
2011-10-20 17:06 ` Doug Anderson
2011-10-20 17:15 ` Mike Frysinger
2011-10-20 18:23 ` Doug Anderson
2011-10-20 19:33 ` Wolfgang Denk
2011-10-20 19:03 ` Wolfgang Denk [this message]
2011-10-21 5:09 ` Doug Anderson
2011-10-19 22:30 ` [U-Boot] [PATCH 2/4] cosmetic: Fixup fixup_silent_linux() for checkpatch Doug Anderson
2011-10-20 14:38 ` Wolfgang Denk
2011-10-19 22:30 ` [U-Boot] [PATCH 3/4] bootm: Avoid 256-byte overflow in fixup_silent_linux() Doug Anderson
2011-10-19 22:51 ` Mike Frysinger
2011-10-20 14:40 ` Wolfgang Denk
2011-10-20 17:54 ` [U-Boot] [PATCH v2] " Doug Anderson
2012-01-10 22:28 ` Wolfgang Denk
2012-01-10 22:51 ` Doug Anderson
2012-01-10 23:31 ` Mike Frysinger
2012-01-10 23:30 ` Mike Frysinger
2012-01-11 18:19 ` Doug Anderson
2012-01-15 1:32 ` Mike Frysinger
2012-01-17 19:16 ` [U-Boot] [PATCH v3] " Doug Anderson
2012-01-17 19:27 ` Mike Frysinger
2012-01-17 19:33 ` Doug Anderson
2012-01-17 19:37 ` [U-Boot] [PATCH v4] " Doug Anderson
2012-01-17 19:55 ` Mike Frysinger
2013-05-22 14:59 ` [U-Boot] [U-Boot, " Tom Rini
2011-10-19 22:30 ` [U-Boot] [PATCH 4/4] bootm: Add earlyprintk to fixup_silent_linux Doug Anderson
2011-10-19 22:35 ` Mike Frysinger
2011-10-19 22:46 ` Doug Anderson
2011-10-19 23:11 ` Mike Frysinger
2011-10-20 14:42 ` Wolfgang Denk
2011-10-20 17:35 ` Doug Anderson
2011-10-20 19:26 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111020190342.374E214094B3@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox