From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Thu, 20 Oct 2011 21:37:07 +0200 Subject: [U-Boot] [PATCH v2 REPOST 2/3] image: Implement IH_TYPE_KERNEL_REL In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF173D51C255@HQMAIL01.nvidia.com> References: <1318972311-673-1-git-send-email-swarren@nvidia.com> <1318972311-673-2-git-send-email-swarren@nvidia.com> <74CDBE0F657A3D45AFBB94109FB122FF173D51BE0F@HQMAIL01.nvidia.com> <20111019200051.AAFEA140ABD3@gemini.denx.de> <74CDBE0F657A3D45AFBB94109FB122FF173D51BFE4@HQMAIL01.nvidia.com> <20111020140404.5241215794DB@gemini.denx.de> <74CDBE0F657A3D45AFBB94109FB122FF173D51C136@HQMAIL01.nvidia.com> <20111020185658.DA2D314094B3@gemini.denx.de> <74CDBE0F657A3D45AFBB94109FB122FF173D51C255@HQMAIL01.nvidia.com> Message-ID: <20111020193707.C2CDB158D103@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stephen Warren, In message <74CDBE0F657A3D45AFBB94109FB122FF173D51C255@HQMAIL01.nvidia.com> you wrote: > > Sorry, but why exactly? Because I'm short of time, and would consider it helpful if you explain that you mean? > The patch I posted doesn't add size to the U-Boot binary without the > configuration option turned on, and I believe should be reviewable and > hopefully even in a state ready to be replied without any further change > or explanation. > > Simon Glass questioned whether the change should be allowed to increase > binary size even when disabled, so as to avoid adding at least some of > the ifdefs. At present, I'm not going to pursue that since it's obvious > that's not what you want. You misunderstand. I am interested in avoiding #ifdef's, but I'm also interested in understanding exactly which price we have to pay instead. > Please, again, just take a look at the patch itself and ignore this part > of the thread. I *really* don't think the patch needs any explanation in > its current form. > > At this point, I'm honestly tempted to just give up on these U-Boot patches. Me too. Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Never put off until tomorrow what you can put off indefinitely.