From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Thu, 20 Oct 2011 23:46:35 +0200 Subject: [U-Boot] [PATCH v2 REPOST 2/3] image: Implement IH_TYPE_KERNEL_REL In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF173D51C286@HQMAIL01.nvidia.com> References: <1318972311-673-1-git-send-email-swarren@nvidia.com> <1318972311-673-2-git-send-email-swarren@nvidia.com> <74CDBE0F657A3D45AFBB94109FB122FF173D51BE0F@HQMAIL01.nvidia.com> <20111019200051.AAFEA140ABD3@gemini.denx.de> <74CDBE0F657A3D45AFBB94109FB122FF173D51BFE4@HQMAIL01.nvidia.com> <20111020140404.5241215794DB@gemini.denx.de> <74CDBE0F657A3D45AFBB94109FB122FF173D51C136@HQMAIL01.nvidia.com> <20111020185658.DA2D314094B3@gemini.denx.de> <74CDBE0F657A3D45AFBB94109FB122FF173D51C255@HQMAIL01.nvidia.com> <20111020193929.D6F47158D103@gemini.denx.de> <74CDBE0F657A3D45AFBB94109FB122FF173D51C286@HQMAIL01.nvidia.com> Message-ID: <20111020214635.F0901158D103@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stephen Warren, In message <74CDBE0F657A3D45AFBB94109FB122FF173D51C286@HQMAIL01.nvidia.com> you wrote: > > > DOn;t give up to oearly. My opinion is that #ifdef's are bad, and > > increased code size is bad either. If we can trade off one for the > > other, we should know exactly what we can win here and how much we > > have to pay for that there. That's all I want to know. > > Do you mean the total without /any/ ifdefs? If so, please see where I > answered this question earlier in the thread: > > http://lists.denx.de/pipermail/u-boot/2011-October/104427.html > > The first time I submitted this patch, there were no ifdefs, and you > stated that the additional 576 bytes text plus 136 bytes rodata was > unacceptable, so I rewrote the patch to add ifdefs everywhere. The statement that triggered me was "Maybe relax that by a few 10s of bytes?", and my question was then ``how much is "a few 10s of bytes"''? Obviously this must be something inbetween the 700+ bytes you state here, and the zero bytes you state elsewhere. I wonder what exactly it was, then? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Lots of folks confuse bad management with destiny. -- Frank Hubbard