From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] [PATCH 00/39] Rework of the debug() macro
Date: Sat, 22 Oct 2011 16:19:55 +0200 [thread overview]
Message-ID: <201110221619.55305.marek.vasut@gmail.com> (raw)
In-Reply-To: <4EA2917B.30108@aribaud.net>
On Saturday, October 22, 2011 11:48:43 AM Albert ARIBAUD wrote:
> Le 22/10/2011 03:18, Marek Vasut a ?crit :
> > On Saturday, October 22, 2011 02:35:13 AM Albert ARIBAUD wrote:
> >> Hi Marek,
> >>
> >> Le 22/10/2011 02:16, Marek Vasut a ?crit :
> >>> This patch series reworks the debug() and debugX() macro in
> >>> include/common.h to be compatible with GCC 4.6.
> >>>
> >>> This series needs further discussion:
> >>> * Some files suffer size growth with gcc4.2, why ?
> >>>
> >>> - Possibility is that the GCC4.2 is incapable to optimize code out
> >>> so deep
> >>>
> >>> * Does this change break any platforms? Compile tested on PowerPC.
> >>>
> >>> - Please run MAKEALL on your platforms to test this.
> >>
> >> Any git branch we could pull and rebase on our trees rather than am'ing
> >> 39 patches one by one?
> >
> > Please try:
> >
> > git://git.denx.de/u-boot-marex.git , "debug" branch.
> >
> > Cheers
>
> A differential 'MAKEALL arm' (ELDK42) show a sharp rise in board not
> building properly, from 74 to 141 (out of a total of 248).
This was expected ... will fix.
>
> Of the 67 boards, many show , essentially due to a lot of printf format
> warnings such as:
>
> ks8695eth.c: In function 'ks8695_eth_send':
> ks8695eth.c:199: warning: format '%x' expects type 'unsigned int', but
> argument 4 has type 'volatile void *'
>
> (in cm4008, cm41xx), or
>
> lcd.c: In function 'lcd_setmem':
> lcd.c:446: warning: format '%d' expects type 'int', but argument 2 has
> type 'u_long'
> lcd.c:446: warning: format '%d' expects type 'int', but argument 3 has
> type 'u_long'
>
> (in at91sam9261ek_nandflash). Another, different, case is smdk2410:
>
> s3c2410_nand.c: In function 's3c2410_hwcontrol':
> s3c2410_nand.c:59: error: 'DEBUG' undeclared (first use in this function)
> s3c2410_nand.c:59: error: (Each undeclared identifier is reported only once
> s3c2410_nand.c:59: error: for each function it appears in.)
> s3c2410_nand.c: In function 's3c2410_dev_ready':
> s3c2410_nand.c:86: error: 'DEBUG' undeclared (first use in this function)
> s3c2410_nand.c: In function 'board_nand_init':
>
> Seems like you're trading some warnings against some others, depending
> on the compiler. :(
Not trading, the typechecking wasn't there and now that it is there, these kind
of warnings keep popping up. Did you ever try to build those boards with DEBUG
enabled?
Cheers
next prev parent reply other threads:[~2011-10-22 14:19 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-22 0:16 [U-Boot] [RFC] [PATCH 00/39] Rework of the debug() macro Marek Vasut
2011-10-22 0:16 ` [U-Boot] [PATCH 01/39] DEBUG: Fix debug macros Marek Vasut
2011-10-23 5:37 ` Mike Frysinger
2011-10-23 17:12 ` Wolfgang Denk
2011-10-25 20:10 ` Joe Hershberger
2011-10-25 20:40 ` 馬克泡
2011-10-25 21:59 ` Wolfgang Denk
2011-10-25 22:08 ` Joe Hershberger
2011-10-24 4:31 ` Simon Glass
2011-10-24 8:21 ` Marek Vasut
2011-10-24 19:21 ` Wolfgang Denk
2011-10-25 0:11 ` Marek Vasut
2011-10-25 7:37 ` Wolfgang Denk
2011-10-25 8:27 ` Marek Vasut
2011-10-25 8:49 ` Graeme Russ
2011-10-25 9:03 ` Marek Vasut
2011-10-25 18:34 ` Wolfgang Denk
2011-10-22 0:16 ` [U-Boot] [PATCH 02/39] GCC4.6: Squash warnings in common/usb.c Marek Vasut
2011-10-24 12:15 ` Stefano Babic
2011-10-24 12:22 ` Marek Vasut
2011-10-24 19:37 ` Wolfgang Denk
2011-10-25 0:09 ` Marek Vasut
2011-10-22 0:16 ` [U-Boot] [PATCH 03/39] GCC4.6: Squash warning in cmd_ide.c Marek Vasut
2011-10-22 0:16 ` [U-Boot] [PATCH 04/39] GCC4.6: Squash warning in cmd_date.c Marek Vasut
2011-10-30 19:59 ` Mike Frysinger
2011-10-22 0:17 ` [U-Boot] [PATCH 05/39] GCC4.6: Squash warning in usb_storage.c Marek Vasut
2011-10-23 5:39 ` Mike Frysinger
2011-10-22 0:17 ` [U-Boot] [PATCH 06/39] GCC4.6: Squash subsequent warnings " Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 07/39] PowerPC: Squash warning in mpc512x serial.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 08/39] GCC4.6: Squash warning in mpc5121ads.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 09/39] GCC4.6: Squash warning in cfb_console.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 10/39] GCC4.6: Squash warning in cfi_flash.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 11/39] GCC4.6: Squash warnings in denali_data_eye.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 12/39] GCC4.6: Squash warnings in denali_spd_ddr2.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 13/39] GCC4.6: Squash warnings in diu.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 14/39] GCC4.6: Squash warnings in mpc8610hpcd.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 15/39] GCC4.6: Squash warnings in tqm834x.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 16/39] GCC4.6: Squash warning in jedec_flash.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 17/39] GCC4.6: Squash warnings in 44x_spd_ddr.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 18/39] GCC4.6: Squash warnings in 4xx_enet.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 19/39] GCC4.6: Squash warnings in 4xx_ibm_ddr2_autocalib.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 20/39] GCC4.6: Squash warnings in 4xx_pcie.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 21/39] GCC4.6: Squash warnings in ahci.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 22/39] GCC4.6: Squash warning in cmd_pmc440.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 23/39] GCC4.6: Use dst instead of l2srbar in cpu_early_init.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 24/39] GCC4.6: Squash warnings in ddr[123]_dimm_params.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 25/39] GCC4.6: Squash warnings in fsl_espi.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 26/39] GCC4.6: Squash warnings in fsl_pci_init.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 27/39] GCC4.6: Squash warnings in pmc405de.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 28/39] GCC4.6: Squash warnings in sata_sil3114.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 29/39] GCC4.6: Squash warnings in tqm8xx_pcmcia.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 30/39] GCC4.6: Squash undefined variable in cmd_mtdparts.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 31/39] GCC4.6: Squash warnings in serial_xuartlite.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 32/39] GCC4.6: Squash warnings in mpc86xx/interrupts.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 33/39] GCC4.6: Squash warnings in r360mpi/flash.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 34/39] GCC4.6: Squash warnings in PPChameleonEVB/flash.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 35/39] GCC4.6: Squash error in pcmcia/i82365.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 36/39] GCC4.6: Squash error in cpc45/pd67290.c Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 37/39] RFT GCC4.6: Fix muas3001 and IDS8247 Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 38/39] GCC4.6: Squash GTREADREG related errors Marek Vasut
2011-10-22 0:17 ` [U-Boot] [PATCH 39/39] GCC4.6: Add macros to mv_gen_reg.h Marek Vasut
2011-10-22 0:35 ` [U-Boot] [RFC] [PATCH 00/39] Rework of the debug() macro Albert ARIBAUD
2011-10-22 1:18 ` Marek Vasut
2011-10-22 9:48 ` Albert ARIBAUD
2011-10-22 14:19 ` Marek Vasut [this message]
2011-10-22 15:23 ` Albert ARIBAUD
2011-10-22 22:17 ` Marek Vasut
2011-10-24 10:10 ` Detlev Zundel
2011-10-24 10:16 ` Marek Vasut
2011-10-24 11:52 ` Detlev Zundel
2011-10-24 12:33 ` Marek Vasut
2011-10-23 5:33 ` Mike Frysinger
2011-10-25 9:04 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110221619.55305.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox