* [U-Boot] debugX macro
@ 2011-10-23 14:46 Marek Vasut
2011-10-23 17:23 ` Wolfgang Denk
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2011-10-23 14:46 UTC (permalink / raw)
To: u-boot
Hi,
I've been doing the debug() cleanup and found the debugX() macro is used only in
very few patches. Maybe punting it altogether won't hurt.
The following do use it:
./board/spc1920/hpi.c
./drivers/mtd/nand/s3c2410_nand.c
Opinions?
Thanks, Cheers!
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] debugX macro
2011-10-23 14:46 [U-Boot] debugX macro Marek Vasut
@ 2011-10-23 17:23 ` Wolfgang Denk
2011-10-23 20:46 ` Marek Vasut
2011-10-25 17:11 ` Joe Hershberger
0 siblings, 2 replies; 5+ messages in thread
From: Wolfgang Denk @ 2011-10-23 17:23 UTC (permalink / raw)
To: u-boot
Dear Marek Vasut,
In message <201110231646.59439.marek.vasut@gmail.com> you wrote:
>
> I've been doing the debug() cleanup and found the debugX() macro is used only in
> very few patches. Maybe punting it altogether won't hurt.
>
> The following do use it:
> ./board/spc1920/hpi.c
> ./drivers/mtd/nand/s3c2410_nand.c
>
> Opinions?
Dump it!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Beware of programmers carrying screwdrivers." - Chip Salzenberg
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] debugX macro
2011-10-23 17:23 ` Wolfgang Denk
@ 2011-10-23 20:46 ` Marek Vasut
2011-10-25 17:11 ` Joe Hershberger
1 sibling, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2011-10-23 20:46 UTC (permalink / raw)
To: u-boot
On Sunday, October 23, 2011 07:23:26 PM Wolfgang Denk wrote:
> Dear Marek Vasut,
>
> In message <201110231646.59439.marek.vasut@gmail.com> you wrote:
> > I've been doing the debug() cleanup and found the debugX() macro is used
> > only in very few patches. Maybe punting it altogether won't hurt.
> >
> > The following do use it:
> > ./board/spc1920/hpi.c
> > ./drivers/mtd/nand/s3c2410_nand.c
> >
> > Opinions?
>
> Dump it!
Dumped on next iteration of the GCC4.6 cleanups!
Cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] debugX macro
2011-10-23 17:23 ` Wolfgang Denk
2011-10-23 20:46 ` Marek Vasut
@ 2011-10-25 17:11 ` Joe Hershberger
2011-10-25 22:16 ` Marek Vasut
1 sibling, 1 reply; 5+ messages in thread
From: Joe Hershberger @ 2011-10-25 17:11 UTC (permalink / raw)
To: u-boot
On Sun, Oct 23, 2011 at 12:23 PM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Marek Vasut,
>
> In message <201110231646.59439.marek.vasut@gmail.com> you wrote:
>>
>> I've been doing the debug() cleanup and found the debugX() macro is used only in
>> very few patches. Maybe punting it altogether won't hurt.
>>
>> The following do use it:
>> ./board/spc1920/hpi.c
>> ./drivers/mtd/nand/s3c2410_nand.c
>>
>> Opinions?
>
> Dump it!
I'm working on a patch to rework the net subsystem and I find it quite
useful for filtering debug traces to a manageable level. I think it
should stay around.
Thanks
-Joe
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] debugX macro
2011-10-25 17:11 ` Joe Hershberger
@ 2011-10-25 22:16 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2011-10-25 22:16 UTC (permalink / raw)
To: u-boot
> On Sun, Oct 23, 2011 at 12:23 PM, Wolfgang Denk <wd@denx.de> wrote:
> > Dear Marek Vasut,
> >
> > In message <201110231646.59439.marek.vasut@gmail.com> you wrote:
> >> I've been doing the debug() cleanup and found the debugX() macro is used
> >> only in very few patches. Maybe punting it altogether won't hurt.
> >>
> >> The following do use it:
> >> ./board/spc1920/hpi.c
> >> ./drivers/mtd/nand/s3c2410_nand.c
> >>
> >> Opinions?
> >
> > Dump it!
>
> I'm working on a patch to rework the net subsystem and I find it quite
> useful for filtering debug traces to a manageable level. I think it
> should stay around.
>
> Thanks
> -Joe
Hi Joe,
why can't you just reimplement it properly with your patchset ? Currently, all
the uses of this macro in the tree are bogus so your code might be a good
example.
Cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-10-25 22:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-23 14:46 [U-Boot] debugX macro Marek Vasut
2011-10-23 17:23 ` Wolfgang Denk
2011-10-23 20:46 ` Marek Vasut
2011-10-25 17:11 ` Joe Hershberger
2011-10-25 22:16 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox