[U-Boot] debugX macro

[U-Boot] debugX macro

[Marek Vasut]

Hi,

I've been doing the debug() cleanup and found the debugX() macro is used only in 
very few patches. Maybe punting it altogether won't hurt.

The following do use it:
./board/spc1920/hpi.c
./drivers/mtd/nand/s3c2410_nand.c

Opinions?

Thanks, Cheers!

[U-Boot] debugX macro

[Wolfgang Denk]

Dear Marek Vasut,

In message <201110231646.59439.marek.vasut@gmail.com> you wrote:
> 
> I've been doing the debug() cleanup and found the debugX() macro is used only in 
> very few patches. Maybe punting it altogether won't hurt.
> 
> The following do use it:
> ./board/spc1920/hpi.c
> ./drivers/mtd/nand/s3c2410_nand.c
> 
> Opinions?

Dump it!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Beware of programmers carrying screwdrivers."      - Chip Salzenberg

[U-Boot] debugX macro

[Marek Vasut]

On Sunday, October 23, 2011 07:23:26 PM Wolfgang Denk wrote:
> Dear Marek Vasut,
> 
> In message <201110231646.59439.marek.vasut@gmail.com> you wrote:
> > I've been doing the debug() cleanup and found the debugX() macro is used
> > only in very few patches. Maybe punting it altogether won't hurt.
> > 
> > The following do use it:
> > ./board/spc1920/hpi.c
> > ./drivers/mtd/nand/s3c2410_nand.c
> > 
> > Opinions?
> 
> Dump it!

Dumped on next iteration of the GCC4.6 cleanups!

Cheers

[U-Boot] debugX macro

[Joe Hershberger]

On Sun, Oct 23, 2011 at 12:23 PM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Marek Vasut,
>
> In message <201110231646.59439.marek.vasut@gmail.com> you wrote:
>>
>> I've been doing the debug() cleanup and found the debugX() macro is used only in
>> very few patches. Maybe punting it altogether won't hurt.
>>
>> The following do use it:
>> ./board/spc1920/hpi.c
>> ./drivers/mtd/nand/s3c2410_nand.c
>>
>> Opinions?
>
> Dump it!

I'm working on a patch to rework the net subsystem and I find it quite
useful for filtering debug traces to a manageable level.  I think it
should stay around.

Thanks
-Joe

[U-Boot] debugX macro

[Marek Vasut]

> On Sun, Oct 23, 2011 at 12:23 PM, Wolfgang Denk <wd@denx.de> wrote:
> > Dear Marek Vasut,
> > 
> > In message <201110231646.59439.marek.vasut@gmail.com> you wrote:
> >> I've been doing the debug() cleanup and found the debugX() macro is used
> >> only in very few patches. Maybe punting it altogether won't hurt.
> >> 
> >> The following do use it:
> >> ./board/spc1920/hpi.c
> >> ./drivers/mtd/nand/s3c2410_nand.c
> >> 
> >> Opinions?
> > 
> > Dump it!
> 
> I'm working on a patch to rework the net subsystem and I find it quite
> useful for filtering debug traces to a manageable level.  I think it
> should stay around.
> 
> Thanks
> -Joe

Hi Joe,

why can't you just reimplement it properly with your patchset ? Currently, all 
the uses of this macro in the tree are bogus so your code might be a good 
example.

Cheers