From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch
Date: Mon, 24 Oct 2011 21:13:57 +0200 [thread overview]
Message-ID: <20111024191357.079A014094B3@gemini.denx.de> (raw)
In-Reply-To: <1319427875-29965-1-git-send-email-sjg@chromium.org>
Dear Simon Glass,
In message <1319427875-29965-1-git-send-email-sjg@chromium.org> you wrote:
> Commit dc8bbea removed a local variable that is used in most ARM boards.
>
> Since we want to avoid an 'unused variable' warning with later compilers,
> and the #ifdef logic of whether this variable is required is bit painful,
> this declares the variable local to the block of code that needs it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> Changes in v2:
> - Tidy up to call getenv() in declaration
>
> arch/arm/lib/board.c | 12 ++++++++----
> 1 files changed, 8 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The joys of love made her human and the agonies of love destroyed
her.
-- Spock, "Requiem for Methuselah", stardate 5842.8
next prev parent reply other threads:[~2011-10-24 19:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 0:14 [U-Boot] [PATCH] arm: Correct build error introduced by getenv_ulong() patch Simon Glass
2011-10-24 3:44 ` [U-Boot] [PATCH v2] " Simon Glass
2011-10-24 19:13 ` Wolfgang Denk [this message]
2011-10-25 6:52 ` Albert ARIBAUD
2011-10-25 7:50 ` Wolfgang Denk
2011-10-25 18:21 ` Albert ARIBAUD
2011-10-25 18:26 ` Simon Glass
2011-10-25 19:36 ` Wolfgang Denk
2011-10-25 19:41 ` Simon Glass
2011-10-31 0:44 ` Mike Frysinger
2011-10-31 21:06 ` Simon Glass
2011-10-31 21:40 ` Mike Frysinger
2011-11-08 9:20 ` Detlev Zundel
2011-11-08 15:57 ` Simon Glass
2011-11-08 19:46 ` Albert ARIBAUD
2011-11-08 22:28 ` Simon Glass
2011-11-08 22:49 ` Wolfgang Denk
2011-11-08 23:18 ` Graeme Russ
2011-11-09 13:45 ` Detlev Zundel
2011-11-09 14:30 ` Simon Glass
2011-11-09 14:11 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111024191357.079A014094B3@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox