public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Update s3c24x0 timer implementation
Date: Mon, 24 Oct 2011 21:34:31 +0200	[thread overview]
Message-ID: <20111024193431.E09B214094B3@gemini.denx.de> (raw)
In-Reply-To: <CAJtrzLNz3TBBRHoNtHkuGci4YJZ9PLrJfvGaR_XdVbrdcprxbQ@mail.gmail.com>

Dear Mark Norman,

In message <CAJtrzLNz3TBBRHoNtHkuGci4YJZ9PLrJfvGaR_XdVbrdcprxbQ@mail.gmail.com> you wrote:
> Dear Wolfgang Denk,
> 
> Thank you for your response.
> 
> >> =A0Since the .rel.text section is required by the relocation code, I
> >> assume that .bss global variables cannot be used until after
> >> relocation?
> >
> > Why do you have to make such assumptions? =A0That's documented
> > behaviour. =A0Didn't you RTFM?
> >
> 
> I thought I had done a thorough search previously but after receiving
> your response I managed to find some of the details outlined in the
> README file.
> 
> I have attached an updated patch below which hopefully addresses the
> other issues you highlighted.

It seems you read my message only halfway through.

> Kind Regards,
> 
> Mark Norman
> 
> 
> 
> The s3c24x0 timer has been updated to use the global_data struct.
> Restructured code based on other timer.c files.
> Updated comments and several parameters.
> 
> Signed-off-by: Mark Norman <mpnorman@gmail.com>
> ---

I wrote before:

Then please submit a proper patch - these introductory comments don't
belong into the commit message and should be moved into the comment
section (below the "---" line).


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Sometimes a feeling is all we humans have to go on.
	-- Kirk, "A Taste of Armageddon", stardate 3193.9

  parent reply	other threads:[~2011-10-24 19:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-23 11:52 [U-Boot] [PATCH] Update s3c24x0 timer implementation Mark Norman
2011-10-23 17:22 ` Wolfgang Denk
2011-10-24 11:27   ` Mark Norman
2011-10-24 13:58     ` Marek Vasut
2011-10-31 11:27       ` Mark Norman
2011-10-24 19:34     ` Wolfgang Denk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-10-31 10:58 Mark Norman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111024193431.E09B214094B3@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox