From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] I2C: Fix mxc_i2c.c problem on phycore pcm037
Date: Tue, 25 Oct 2011 16:59:25 +0200 [thread overview]
Message-ID: <20111025165925.2c62689d@wker> (raw)
In-Reply-To: <1319544551-24639-1-git-send-email-marek.vasut@gmail.com>
Hi Marek,
On Tue, 25 Oct 2011 14:09:11 +0200
Marek Vasut <marek.vasut@gmail.com> wrote:
> The problem was caused by a global variable being used early in the boot
> process.
>
> This patch also contains the multibyte address swapping fix by:
> Anatolij Gustschin <agust@denx.de>
>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Anatolij Gustschin <agust@denx.de>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> drivers/i2c/mxc_i2c.c | 29 ++++++++++++++++-------------
> 1 files changed, 16 insertions(+), 13 deletions(-)
Great, this patch fixes the issue! Thanks!
Tested-by: Anatolij Gustschin <agust@denx.de>
But, I think we should slightly fix the commit title and commit
message to describe the observed problem better.
The board is named as "imx31_phycore" in the code, config
file uses this name, too. So we should use "imx31_phycore" name in
U-Boot commits instead of pcm037 to avoid confusion for other users
(pcm037 name is used in Linux code for this board).
In the commit message we should also mention what the problem was:
on imx31_phycore board reading the environment from I2C EEPROM
didn't work correctly.
Thanks,
Anatolij
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2011-10-25 14:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 12:09 [U-Boot] [PATCH] I2C: Fix mxc_i2c.c problem on phycore pcm037 Marek Vasut
2011-10-25 14:59 ` Anatolij Gustschin [this message]
2011-10-25 15:25 ` [U-Boot] [PATCH V2] I2C: Fix mxc_i2c.c problem on imx31_phycore Marek Vasut
2011-10-26 8:25 ` Stefano Babic
2011-10-26 8:59 ` Stefano Babic
2011-10-26 10:08 ` Marek Vasut
2011-10-26 10:05 ` [U-Boot] [PATCH V3] " Marek Vasut
2011-10-26 10:53 ` Stefano Babic
2011-10-26 11:17 ` Heiko Schocher
2011-10-26 13:26 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111025165925.2c62689d@wker \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox