[U-Boot] [PATCH 2/2] mvgbe: fix network device indices

Mike Frysinger
2011-11-03T23:11:50Z

On Thursday 03 November 2011 19:02:26 Michael Walle wrote:
> Am Donnerstag 03 November 2011, 19:10:57 schrieb Mike Frysinger:
> > On Thursday 27 October 2011 17:31:36 Michael Walle wrote:
> > > --- a/drivers/net/mvgbe.c
> > > +++ b/drivers/net/mvgbe.c
> > >
> > > + /* Extract the MAC address from the environment */
> > > + while (!eth_getenv_enetaddr_by_index("eth", dev->index,
> > > + dev->enetaddr)) {
> > >
> > > /* Generate Private MAC addr if not set */
> > > dev->enetaddr[0] = 0x02;
> > > dev->enetaddr[1] = 0x50;
> >
> > this is wrong. net drivers should not be touching the env at all.
> > please fix your driver to not do that first.
>
> i guess this whole mac randomization/generation code belongs to board
> specific files.

correct
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111103/dbdf1c96/attachment.pgp