From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Wed, 26 Oct 2011 00:16:29 +0200
Subject: [U-Boot] debugX macro
In-Reply-To: <CANr=Z=aHrunoWkjCFj1ORsNXSfTegV=S=ACRv24bLn82KBUfog@mail.gmail.com>
References: <201110231646.59439.marek.vasut@gmail.com>
	<20111023172326.827451408771@gemini.denx.de>
	<CANr=Z=aHrunoWkjCFj1ORsNXSfTegV=S=ACRv24bLn82KBUfog@mail.gmail.com>
Message-ID: <201110260016.30086.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> On Sun, Oct 23, 2011 at 12:23 PM, Wolfgang Denk <wd@denx.de> wrote:
> > Dear Marek Vasut,
> > 
> > In message <201110231646.59439.marek.vasut@gmail.com> you wrote:
> >> I've been doing the debug() cleanup and found the debugX() macro is used
> >> only in very few patches. Maybe punting it altogether won't hurt.
> >> 
> >> The following do use it:
> >> ./board/spc1920/hpi.c
> >> ./drivers/mtd/nand/s3c2410_nand.c
> >> 
> >> Opinions?
> > 
> > Dump it!
> 
> I'm working on a patch to rework the net subsystem and I find it quite
> useful for filtering debug traces to a manageable level.  I think it
> should stay around.
> 
> Thanks
> -Joe

Hi Joe,

why can't you just reimplement it properly with your patchset ? Currently, all 
the uses of this macro in the tree are bogus so your code might be a good 
example.

Cheers