public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] I2C: Fix mxc_i2c.c problem on imx31_phycore
Date: Wed, 26 Oct 2011 12:08:50 +0200	[thread overview]
Message-ID: <201110261208.50566.marek.vasut@gmail.com> (raw)
In-Reply-To: <4EA7CBE4.60400@denx.de>

> On 10/26/2011 10:25 AM, Stefano Babic wrote:
> > On 10/25/2011 05:25 PM, Marek Vasut wrote:
> >> The problem was caused by a global variable being used early in the boot
> >> process.
> >> 
> >> The symptoms were on imx31_phycore board, reading the environment from
> >> I2C EEPROM didn't work correctly and causes default environment to be
> >> loaded.
> >> 
> >> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> >> Cc: Wolfgang Denk <wd@denx.de>
> >> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> >> Cc: Heiko Schocher <hs@denx.de>
> >> Cc: Stefano Babic <sbabic@denx.de>
> >> Tested-by: Anatolij Gustschin <agust@denx.de>
> >> ---
> >> 
> >>  drivers/i2c/mxc_i2c.c |   29 ++++++++++++++++-------------
> >>  1 files changed, 16 insertions(+), 13 deletions(-)
> >> 
> >> V2: Fix commit message
> > 
> > Tested on mx35pdk.
> > 
> > Tested-by: Stefano Babic <sbabic@denx.de>
> 
> I tested (and it works), but there is a problem. I supposed it was a
> mistake by me, but after some checks I have found the cause.
> 
> Your patch does not apply on current u-boot-imx. You sent earlier the
> patch:
> 
> "I2C: Add i2c_get/set_speed() to mxc_i2c.c"
> 
> that after Heiko's ACK I have applied to u-boot-imx and then it is
> already merged into u-boot-arm. The patch you have sent now does not
> take care of your previous patch and does not apply anymore.
> 
> Can you rebase your patch ? You can take u-boot-imx als reference, all
> imx related patches are already applied.
> 
> Best regards,
> Stefano Babic

Hi Stefano,

done rebasing on u-boot-imx/master and tested on imx31_phycore.

Cheers

  reply	other threads:[~2011-10-26 10:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-25 12:09 [U-Boot] [PATCH] I2C: Fix mxc_i2c.c problem on phycore pcm037 Marek Vasut
2011-10-25 14:59 ` Anatolij Gustschin
2011-10-25 15:25 ` [U-Boot] [PATCH V2] I2C: Fix mxc_i2c.c problem on imx31_phycore Marek Vasut
2011-10-26  8:25   ` Stefano Babic
2011-10-26  8:59     ` Stefano Babic
2011-10-26 10:08       ` Marek Vasut [this message]
2011-10-26 10:05   ` [U-Boot] [PATCH V3] " Marek Vasut
2011-10-26 10:53     ` Stefano Babic
2011-10-26 11:17       ` Heiko Schocher
2011-10-26 13:26         ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110261208.50566.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox