public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] FAT: Add FAT write feature
Date: Thu, 27 Oct 2011 15:48:29 +0200	[thread overview]
Message-ID: <201110271548.29727.marek.vasut@gmail.com> (raw)
In-Reply-To: <20111026194151.ACC3A11F9E5D@gemini.denx.de>

> Dear Donggeun Kim,
> 
> In message <1319526928-7927-1-git-send-email-dg77.kim@samsung.com> you wrote:
> > In some cases, saving data in RAM as a file with FAT format is required.
> > This patch allows the file to be written in FAT formatted partition.
> > 
> > The usage is similar with reading a file.
> > First, fat_register_device function is called before file_fat_write
> > function in order to set target partition.
> > Then, file_fat_write function is invoked with desired file name,
> > start ram address for writing data, and file size.
> > 
> > Signed-off-by: Donggeun Kim <dg77.kim@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> > 
> > Changes for v2:
> >    - update README file
> >  
> >  README             |    5 +
> >  fs/fat/Makefile    |    1 +
> >  fs/fat/fat.c       |    2 +
> >  fs/fat/fat_write.c | 1091
> >  ++++++++++++++++++++++++++++++++++++++++++++++++++++ include/fat.h     
> >  |    3 +
> >  5 files changed, 1102 insertions(+), 0 deletions(-)
> >  create mode 100644 fs/fat/fat_write.c
> 
> Applied, thanks.

DAMN :-(

Dongguen,

I now get this warning on many boards:
fat.c:49:22: warning: 'part_size' defined but not used

please FIX !

Also, can you avoid using global variables, it's stupid?

Cheers

  reply	other threads:[~2011-10-27 13:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-25  7:15 [U-Boot] [PATCH v2] FAT: Add FAT write feature Donggeun Kim
2011-10-26 19:41 ` Wolfgang Denk
2011-10-27 13:48   ` Marek Vasut [this message]
2011-10-26 22:45 ` Mike Frysinger
2011-10-27 20:55   ` Wolfgang Denk
2011-10-27 21:08     ` Mike Frysinger
2011-10-27 21:10 ` [U-Boot] [PATCH] fs/fat/fat.c: fix warning: 'part_size' defined but not used Wolfgang Denk
2011-12-13  6:15   ` Aaron Williams
2011-12-13  8:18     ` Wolfgang Denk
2011-12-13  8:53       ` Anatolij Gustschin
2011-12-13 11:03         ` Wolfgang Denk
2011-12-13  8:37     ` Donggeun Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110271548.29727.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox