public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] disk: part_efi: fix **pgpt_pte == NULL
Date: Thu, 27 Oct 2011 23:50:08 +0200	[thread overview]
Message-ID: <20111027215008.7C61112B7BBC@gemini.denx.de> (raw)
In-Reply-To: <1319053651-14017-1-git-send-email-dianders@chromium.org>

Dear Doug Anderson,

In message <1319053651-14017-1-git-send-email-dianders@chromium.org> you wrote:
> Code was setting **pgpt_pte == NULL, which meant that the pointer
> to the gpt_pte would be stored at RAM address 00000000. This 'worked'
> on T20 (SDRAM starts @ 0x00000000), but hung gpt/EFI access on T30
> (SDRAM starts @ 0x80000000).
> 
> Signed-off-by: Tom Warren <twarren@nvidia.com>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> v2: No change to patch 1/2 (not reposted); patch 2/2 updated to
> address Mike Frysinger's comments.  Note that %p currently doesn't
> include the "0x" prefix in u-boot, but I expect that it may someday
> (since it does in gcc) so I've gone ahead and removed the prefix.
> 
>  disk/part_efi.c |   38 +++++++++++++++-----------------------
>  1 files changed, 15 insertions(+), 23 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have a very small mind and must live with it.    -- Edsger Dijkstra

  parent reply	other threads:[~2011-10-27 21:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-19 18:04 [U-Boot] [PATCH 1/2] cosmetic: Replace __FUNCTION__ with __func__ in part_efi.c Doug Anderson
2011-10-19 18:04 ` [U-Boot] [PATCH 2/2] disk: part_efi: fix **pgpt_pte == NULL Doug Anderson
2011-10-19 18:21   ` Mike Frysinger
2011-10-19 19:47     ` Doug Anderson
2011-10-19 19:56       ` Mike Frysinger
2011-10-19 19:59         ` Doug Anderson
2011-10-19 20:29           ` Mike Frysinger
2011-10-27 21:50       ` Wolfgang Denk [this message]
2011-10-19 19:33   ` Richard Retanubun
2011-10-19 18:19 ` [U-Boot] [PATCH 1/2] cosmetic: Replace __FUNCTION__ with __func__ in part_efi.c Mike Frysinger
2011-10-19 19:24 ` Richard Retanubun
2011-10-27 21:46 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111027215008.7C61112B7BBC@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox