From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/5] HWW-1U-1A: e1000 driver cleanups and new features
Date: Fri, 28 Oct 2011 06:25:21 +0200 [thread overview]
Message-ID: <20111028042522.094FC1809853@gemini.denx.de> (raw)
In-Reply-To: <1318971929-1160-1-git-send-email-Kyle.D.Moffett@boeing.com>
Dear Kyle Moffett,
In message <1318971929-1160-1-git-send-email-Kyle.D.Moffett@boeing.com> you wrote:
> This is a reposted patch series from several months that enhances the
> e1000 driver in U-Boot to support the Intel 82571EB and provides
> several new features for the board manufacturing process.
>
> Based on prior review, the EEPROM programming and SPI code has been
> moved into a separate file, "e1000_spi.c", and it calls a few exported
> functions in the main e1000.c file to coordinate EEPROM access.
>
> Comments, critiques, and compliments are highly appreciated.
Critique: I wonder how you tested your patches, if at all :-(
They generate a ton of warnings:
e1000.c: In function 'e1000_raise_ee_clk':
e1000.c:155: warning: unused variable 'x'
e1000.c: In function 'e1000_lower_ee_clk':
e1000.c:172: warning: unused variable 'x'
e1000.c: In function 'e1000_shift_out_ee_bits':
e1000.c:208: warning: unused variable 'x'
e1000.c: In function 'e1000_standby_eeprom':
e1000.c:279: warning: unused variable 'x'
e1000.c:285: warning: unused variable 'x'
e1000.c:291: warning: unused variable 'x'
e1000.c:297: warning: unused variable 'x'
e1000.c:303: warning: unused variable 'x'
e1000.c:307: warning: unused variable 'x'
e1000.c: In function 'e1000_release_eeprom':
e1000.c:689: warning: unused variable 'x'
e1000.c:695: warning: unused variable 'x'
e1000.c: In function 'e1000_reset_hw':
e1000.c:1401: warning: unused variable 'x'
e1000.c:1428: warning: unused variable 'x'
e1000.c: In function 'e1000_init_hw':
e1000.c:1635: warning: unused variable 'x'
e1000.c:1647: warning: unused variable 'x'
e1000.c:1661: warning: unused variable 'x'
e1000.c: In function 'e1000_setup_fiber_link':
e1000.c:2029: warning: unused variable 'x'
e1000.c: In function 'e1000_config_collision_dist':
e1000.c:3235: warning: unused variable 'x'
e1000.c: In function 'e1000_raise_mdi_clk':
e1000.c:3960: warning: unused variable 'x'
e1000.c: In function 'e1000_lower_mdi_clk':
e1000.c:3977: warning: unused variable 'x'
e1000.c: In function 'e1000_shift_out_mdi_bits':
e1000.c:4020: warning: unused variable 'x'
e1000.c: In function 'e1000_shift_in_mdi_bits':
e1000.c:4059: warning: unused variable 'x'
e1000.c: In function 'e1000_phy_hw_reset':
e1000.c:4341: warning: unused variable 'x'
e1000.c:4349: warning: unused variable 'x'
e1000.c:4362: warning: unused variable 'x'
e1000.c:4366: warning: unused variable 'x'
e1000.c: In function 'e1000_configure_rx':
e1000.c:4991: warning: unused variable 'x'
e1000.c: In function 'e1000_transmit':
e1000.c:5049: warning: unused variable 'x'
e1000.c: In function 'e1000_initialize':
e1000.c:869: warning: 'checksum' may be used uninitialized in this function
e1000.c:869: note: 'checksum' was declared here
Please fix!!!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I am a computer. I am dumber than any human and smarter than any ad-
ministrator.
next prev parent reply other threads:[~2011-10-28 4:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 21:05 [U-Boot] [PATCH 0/5] HWW-1U-1A: e1000 driver cleanups and new features Kyle Moffett
2011-10-18 21:05 ` [U-Boot] [PATCH 1/5] e1000: Clean up handling of dual-port NICs and support 82571 Kyle Moffett
2011-10-27 22:34 ` Wolfgang Denk
2011-10-18 21:05 ` [U-Boot] [PATCH 2/5] e1000: Restructure and streamline PCI device probing Kyle Moffett
2011-10-27 22:34 ` Wolfgang Denk
2011-10-18 21:05 ` [U-Boot] [PATCH 3/5] e1000: Rewrite EEPROM checksum error to give more information Kyle Moffett
2011-10-27 22:35 ` Wolfgang Denk
2011-10-18 21:05 ` [U-Boot] [PATCH 4/5] e1000: Export core EEPROM access functions for SPI support Kyle Moffett
2011-10-27 22:35 ` Wolfgang Denk
2011-11-01 15:22 ` Tabi Timur-B04825
2011-11-01 15:30 ` Mike Frysinger
2011-10-18 21:05 ` [U-Boot] [PATCH 5/5] e1000: Allow direct access to the E1000 SPI EEPROM device Kyle Moffett
2011-10-27 22:37 ` Wolfgang Denk
2011-10-28 4:25 ` Wolfgang Denk [this message]
2011-10-28 5:49 ` [U-Boot] [PATCH] e1000: fix bugs from recent commits Wolfgang Denk
2011-10-28 6:28 ` Mike Frysinger
2011-10-28 20:19 ` Wolfgang Denk
2011-10-28 23:30 ` Mike Frysinger
2011-10-29 19:32 ` Wolfgang Denk
2011-10-28 17:24 ` Moffett, Kyle D
2011-10-28 20:40 ` Wolfgang Denk
2011-10-28 21:06 ` Marek Vasut
2011-10-29 19:33 ` [U-Boot] [PATCH v2] " Wolfgang Denk
2011-10-30 15:43 ` Mike Frysinger
2011-10-31 15:14 ` Moffett, Kyle D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028042522.094FC1809853@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox