From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] e1000: fix bugs from recent commits
Date: Fri, 28 Oct 2011 23:06:59 +0200 [thread overview]
Message-ID: <201110282306.59972.marek.vasut@gmail.com> (raw)
In-Reply-To: <1319780953-10594-1-git-send-email-wd@denx.de>
> Commit 114d7fc0 "e1000: Rewrite EEPROM checksum error to give more
> information" failed to initialize the checksum variable which should
> result in random results. Fix that.
> [I wonder if that code has _ever_ been tested!!]
>
> Commit 2326a94d caused a ton of "unused variable 'x'" warnings.
> Fix these. While we are at it, remove some bogus parens.
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Kyle Moffett <Kyle.D.Moffett@boeing.com>
> ---
>
> Kyle,
>
> I wonder if you have ever actually build and run this code???
> With the "checksum" variable being random (due to not being
> initialized) you should have seen serious checksum problems.
> How did this escape your testing?
>
> And all these build warnings - have you ever actully compiled that
> code? What's going on here??? - wd
>
> Marek: Could you please be so kind and have a look at the debug code?
> I think this needs a major cleanup, too. Thanks in advance. - wd
I might take a sneak peek ... -mv
next prev parent reply other threads:[~2011-10-28 21:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 21:05 [U-Boot] [PATCH 0/5] HWW-1U-1A: e1000 driver cleanups and new features Kyle Moffett
2011-10-18 21:05 ` [U-Boot] [PATCH 1/5] e1000: Clean up handling of dual-port NICs and support 82571 Kyle Moffett
2011-10-27 22:34 ` Wolfgang Denk
2011-10-18 21:05 ` [U-Boot] [PATCH 2/5] e1000: Restructure and streamline PCI device probing Kyle Moffett
2011-10-27 22:34 ` Wolfgang Denk
2011-10-18 21:05 ` [U-Boot] [PATCH 3/5] e1000: Rewrite EEPROM checksum error to give more information Kyle Moffett
2011-10-27 22:35 ` Wolfgang Denk
2011-10-18 21:05 ` [U-Boot] [PATCH 4/5] e1000: Export core EEPROM access functions for SPI support Kyle Moffett
2011-10-27 22:35 ` Wolfgang Denk
2011-11-01 15:22 ` Tabi Timur-B04825
2011-11-01 15:30 ` Mike Frysinger
2011-10-18 21:05 ` [U-Boot] [PATCH 5/5] e1000: Allow direct access to the E1000 SPI EEPROM device Kyle Moffett
2011-10-27 22:37 ` Wolfgang Denk
2011-10-28 4:25 ` [U-Boot] [PATCH 0/5] HWW-1U-1A: e1000 driver cleanups and new features Wolfgang Denk
2011-10-28 5:49 ` [U-Boot] [PATCH] e1000: fix bugs from recent commits Wolfgang Denk
2011-10-28 6:28 ` Mike Frysinger
2011-10-28 20:19 ` Wolfgang Denk
2011-10-28 23:30 ` Mike Frysinger
2011-10-29 19:32 ` Wolfgang Denk
2011-10-28 17:24 ` Moffett, Kyle D
2011-10-28 20:40 ` Wolfgang Denk
2011-10-28 21:06 ` Marek Vasut [this message]
2011-10-29 19:33 ` [U-Boot] [PATCH v2] " Wolfgang Denk
2011-10-30 15:43 ` Mike Frysinger
2011-10-31 15:14 ` Moffett, Kyle D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110282306.59972.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox