From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 28 Oct 2011 23:06:59 +0200 Subject: [U-Boot] [PATCH] e1000: fix bugs from recent commits In-Reply-To: <1319780953-10594-1-git-send-email-wd@denx.de> References: <1318971929-1160-1-git-send-email-Kyle.D.Moffett@boeing.com> <1319780953-10594-1-git-send-email-wd@denx.de> Message-ID: <201110282306.59972.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > Commit 114d7fc0 "e1000: Rewrite EEPROM checksum error to give more > information" failed to initialize the checksum variable which should > result in random results. Fix that. > [I wonder if that code has _ever_ been tested!!] > > Commit 2326a94d caused a ton of "unused variable 'x'" warnings. > Fix these. While we are at it, remove some bogus parens. > > Signed-off-by: Wolfgang Denk > Cc: Kyle Moffett > --- > > Kyle, > > I wonder if you have ever actually build and run this code??? > With the "checksum" variable being random (due to not being > initialized) you should have seen serious checksum problems. > How did this escape your testing? > > And all these build warnings - have you ever actully compiled that > code? What's going on here??? - wd > > Marek: Could you please be so kind and have a look at the debug code? > I think this needs a major cleanup, too. Thanks in advance. - wd I might take a sneak peek ... -mv