[U-Boot] build fail for config_dockstar

[U-Boot] build fail for config_dockstar

[Roland Kletzing]

hi,
i`m not 100% sure if this is not?my fault (because of build environment), but?as this does not happen with u-boot-2011.09.tar.bz2, i`m curious if current dockstar build is brocken in current git.

i was following http://jeff.doozan.com/debian/uboot/build_uboot.htm?and found, that dockstar config option is in uboot sinc november last year, and i want to try a more recent version (via?2nd stage from mtd3) because of the usb boot problems i have with the build which comes with http://jeff.doozan.com/debian/[http://jeff.doozan.com/debian/]?
i left off the?mentioned?mtd3 patch from the description at jeff`s site and "make dockstar_config; make" results in the following lines (see below).

maybe someone can reproduce this and/or want`s to have a look.

regards
roland

<snip>
make[1]: Leaving directory `/install/uboot-git/u-boot/net'
make -C post/
make[1]: Entering directory `/install/uboot-git/u-boot/post'
cat /dev/null? >.depend
make[1]: Leaving directory `/install/uboot-git/u-boot/post'
make[1]: Entering directory `/install/uboot-git/u-boot/post'
rm -f libpost.o; ar rcs libpost.o
make[1]: Leaving directory `/install/uboot-git/u-boot/post'
make -C board/Seagate/dockstar/
make[1]: Entering directory `/install/uboot-git/u-boot/board/Seagate/dockstar'
gcc -M -g? -Os?? -fno-common -ffixed-r8 -msoft-float? -D__KERNEL__ -DCONFIG_SYS_TEXT_BASE=0x00600000 -I/install/uboot-git/u-boot/include -fno-builtin -ffreestanding -nostdinc -isystem /usr/lib/gcc/arm-linux-gnueabi/4.4.5/include -pipe? -DCONFIG_ARM -D__ARM__ -marm? -mabi=aapcs-linux -mno-thumb-interwork -march=armv5te?? -MQ dockstar.o dockstar.c >.depend.dockstar
cat /dev/null .depend.dockstar >.depend
make[1]: Leaving directory `/install/uboot-git/u-boot/board/Seagate/dockstar'
make[1]: Entering directory `/install/uboot-git/u-boot/board/Seagate/dockstar'
gcc? -g? -Os?? -fno-common -ffixed-r8 -msoft-float? -D__KERNEL__ -DCONFIG_SYS_TEXT_BASE=0x00600000 -I/install/uboot-git/u-boot/include -fno-builtin -ffreestanding -nostdinc -isystem /usr/lib/gcc/arm-linux-gnueabi/4.4.5/include -pipe? -DCONFIG_ARM -D__ARM__ -marm? -mabi=aapcs-linux -mno-thumb-interwork -march=armv5te -Wall -Wstrict-prototypes -fno-stack-protector -Wno-format-nonliteral -Wno-format-security???? -o dockstar.o dockstar.c -c
dockstar.c: In function 'board_early_init_f':
dockstar.c:43: warning: implicit declaration of function 'kw_config_gpio'
dockstar.c: In function 'board_init':
dockstar.c:113: warning: implicit declaration of function 'kw_sdram_bar'
dockstar.c: In function 'set_leds':
dockstar.c:161: warning: implicit declaration of function 'readl'
dockstar.c:161: error: dereferencing pointer to incomplete type
dockstar.c:162: warning: implicit declaration of function 'writel'
dockstar.c:162: error: dereferencing pointer to incomplete type
dockstar.c:163: error: dereferencing pointer to incomplete type
dockstar.c:164: error: dereferencing pointer to incomplete type
make[1]: *** [dockstar.o] Error 1
make[1]: Leaving directory `/install/uboot-git/u-boot/board/Seagate/dockstar'
make: *** [board/Seagate/dockstar/libdockstar.o] Error 2
root at debian:/install/uboot-git/u-boot[mailto:root at debian:/install/uboot-git/u-boot]#

___________________________________________________________
SMS schreiben mit WEB.DE FreeMail - einfach, schnell und
kostenguenstig. Jetzt gleich testen! http://f.web.de/?mc=021192

[U-Boot] build fail for config_dockstar

[Eric Cooper]

On Sat, Oct 29, 2011 at 06:52:08PM +0200, Roland Kletzing wrote:
> i`m not 100% sure if this is not?my fault (because of build
> environment), but?as this does not happen with
> u-boot-2011.09.tar.bz2, i`m curious if current dockstar build is
> brocken in current git.
> [...]
> gcc? -g? -Os?? -fno-common -ffixed-r8 -msoft-float? -D__KERNEL__ -DCONFIG_SYS_TEXT_BASE=0x00600000 -I/install/uboot-git/u-boot/include -fno-builtin -ffreestanding -nostdinc -isystem /usr/lib/gcc/arm-linux-gnueabi/4.4.5/include -pipe? -DCONFIG_ARM -D__ARM__ -marm? -mabi=aapcs-linux -mno-thumb-interwork -march=armv5te -Wall -Wstrict-prototypes -fno-stack-protector -Wno-format-nonliteral -Wno-format-security???? -o dockstar.o dockstar.c -c
> dockstar.c: In function 'board_early_init_f':
> dockstar.c:43: warning: implicit declaration of function 'kw_config_gpio'
> dockstar.c: In function 'board_init':
> dockstar.c:113: warning: implicit declaration of function 'kw_sdram_bar'
> dockstar.c: In function 'set_leds':
> dockstar.c:161: warning: implicit declaration of function 'readl'
> dockstar.c:161: error: dereferencing pointer to incomplete type
> dockstar.c:162: warning: implicit declaration of function 'writel'
> dockstar.c:162: error: dereferencing pointer to incomplete type
> dockstar.c:163: error: dereferencing pointer to incomplete type
> dockstar.c:164: error: dereferencing pointer to incomplete type
> make[1]: *** [dockstar.o] Error 1
> make[1]: Leaving directory `/install/uboot-git/u-boot/board/Seagate/dockstar'
> make: *** [board/Seagate/dockstar/libdockstar.o] Error 2
> root at debian:/install/uboot-git/u-boot[mailto:root at debian:/install/uboot-git/u-boot]#

I can confirm this failure.  "git bisect" shows that the
build was broken by this commit:
    a7efd719 ARM: kirkwood: reduce dependence of including platform file
which patched a number of board files in the Marvell directory, but
not the DockStar.  It's a one-line patch, which will follow.

-- 
Eric Cooper             e c c @ c m u . e d u

[U-Boot] [PATCH] ARM: DockStar: fix compilation

[Anatolij Gustschin]

Fix build problem:

mvgbe.c: In function 'mvgbe_initialize':
mvgbe.c:735: warning: implicit declaration of function 'get_random_hex'
dockstar.c: In function 'board_early_init_f':
dockstar.c:43: warning: implicit declaration of function 'kw_config_gpio'
dockstar.c: In function 'board_init':
dockstar.c:113: warning: implicit declaration of function 'kw_sdram_bar'
dockstar.c: In function 'set_leds':
dockstar.c:161: warning: implicit declaration of function 'readl'
dockstar.c:161: error: dereferencing pointer to incomplete type
dockstar.c:162: warning: implicit declaration of function 'writel'
dockstar.c:162: error: dereferencing pointer to incomplete type
dockstar.c:163: error: dereferencing pointer to incomplete type
dockstar.c:164: error: dereferencing pointer to incomplete type
make[1]: *** [dockstar.o] Error 1
make: *** [board/Seagate/dockstar/libdockstar.o] Error 2

Reported-by: Roland Kletzing <devzero@web.de>
Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Cc: Prafulla Wadaskar <prafulla@marvell.com>
---
 board/Seagate/dockstar/dockstar.c |    2 ++
 drivers/net/mvgbe.c               |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/board/Seagate/dockstar/dockstar.c b/board/Seagate/dockstar/dockstar.c
index cab3a83..3c26a97 100644
--- a/board/Seagate/dockstar/dockstar.c
+++ b/board/Seagate/dockstar/dockstar.c
@@ -30,6 +30,8 @@
 #include <asm/arch/kirkwood.h>
 #include <asm/arch/mpp.h>
 #include "dockstar.h"
+#include <asm/arch/cpu.h>
+#include <asm/io.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c
index c7f7446..fd13428 100644
--- a/drivers/net/mvgbe.c
+++ b/drivers/net/mvgbe.c
@@ -37,6 +37,7 @@
 #include <asm/types.h>
 #include <asm/system.h>
 #include <asm/byteorder.h>
+#include <asm/arch/cpu.h>
 
 #if defined(CONFIG_KIRKWOOD)
 #include <asm/arch/kirkwood.h>
-- 
1.7.1

[U-Boot] [PATCH] ARM: DockStar: fix compilation

[Anatolij Gustschin]

Fix build problem:

mvgbe.c: In function 'mvgbe_initialize':
mvgbe.c:735: warning: implicit declaration of function 'get_random_hex'
dockstar.c: In function 'board_early_init_f':
dockstar.c:43: warning: implicit declaration of function 'kw_config_gpio'
dockstar.c: In function 'board_init':
dockstar.c:113: warning: implicit declaration of function 'kw_sdram_bar'
dockstar.c: In function 'set_leds':
dockstar.c:161: warning: implicit declaration of function 'readl'
dockstar.c:161: error: dereferencing pointer to incomplete type
dockstar.c:162: warning: implicit declaration of function 'writel'
dockstar.c:162: error: dereferencing pointer to incomplete type
dockstar.c:163: error: dereferencing pointer to incomplete type
dockstar.c:164: error: dereferencing pointer to incomplete type
make[1]: *** [dockstar.o] Error 1
make: *** [board/Seagate/dockstar/libdockstar.o] Error 2

Reported-by: Roland Kletzing <devzero@web.de>
Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Cc: Prafulla Wadaskar <prafulla@marvell.com>
---
Changes since first version:
 - move fixing #includes as suggested by Eric

 board/Seagate/dockstar/dockstar.c |    2 ++
 drivers/net/mvgbe.c               |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/board/Seagate/dockstar/dockstar.c b/board/Seagate/dockstar/dockstar.c
index cab3a83..a1de0dc 100644
--- a/board/Seagate/dockstar/dockstar.c
+++ b/board/Seagate/dockstar/dockstar.c
@@ -29,6 +29,8 @@
 #include <miiphy.h>
 #include <asm/arch/kirkwood.h>
 #include <asm/arch/mpp.h>
+#include <asm/arch/cpu.h>
+#include <asm/io.h>
 #include "dockstar.h"
 
 DECLARE_GLOBAL_DATA_PTR;
diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c
index c7f7446..fd13428 100644
--- a/drivers/net/mvgbe.c
+++ b/drivers/net/mvgbe.c
@@ -37,6 +37,7 @@
 #include <asm/types.h>
 #include <asm/system.h>
 #include <asm/byteorder.h>
+#include <asm/arch/cpu.h>
 
 #if defined(CONFIG_KIRKWOOD)
 #include <asm/arch/kirkwood.h>
-- 
1.7.1