* [U-Boot] [PATCH] dockstar: include headers that were removed from kirkwood.h
@ 2011-10-29 19:09 Eric Cooper
2011-10-29 19:41 ` Anatolij Gustschin
0 siblings, 1 reply; 3+ messages in thread
From: Eric Cooper @ 2011-10-29 19:09 UTC (permalink / raw)
To: u-boot
Commit a7efd719f415833a833d6a8e46bcd470a0847ecc removed some #includes
from kirkwood.h that must now be done in dockstar.c
Signed-off-by: Eric Cooper <ecc@cmu.edu>
---
board/Seagate/dockstar/dockstar.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/board/Seagate/dockstar/dockstar.c b/board/Seagate/dockstar/dockstar.c
index cab3a83..9aab62d 100644
--- a/board/Seagate/dockstar/dockstar.c
+++ b/board/Seagate/dockstar/dockstar.c
@@ -27,6 +27,8 @@
#include <common.h>
#include <miiphy.h>
+#include <asm/io.h>
+#include <asm/arch/cpu.h>
#include <asm/arch/kirkwood.h>
#include <asm/arch/mpp.h>
#include "dockstar.h"
--
1.7.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] dockstar: include headers that were removed from kirkwood.h
2011-10-29 19:09 [U-Boot] [PATCH] dockstar: include headers that were removed from kirkwood.h Eric Cooper
@ 2011-10-29 19:41 ` Anatolij Gustschin
2011-10-29 19:54 ` Eric Cooper
0 siblings, 1 reply; 3+ messages in thread
From: Anatolij Gustschin @ 2011-10-29 19:41 UTC (permalink / raw)
To: u-boot
Hi Eric,
On Sat, 29 Oct 2011 15:09:40 -0400
Eric Cooper <ecc@cmu.edu> wrote:
> Commit a7efd719f415833a833d6a8e46bcd470a0847ecc removed some #includes
> from kirkwood.h that must now be done in dockstar.c
>
> Signed-off-by: Eric Cooper <ecc@cmu.edu>
> ---
> board/Seagate/dockstar/dockstar.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
There is another similar patch also fixing compiler warning for mvgbe.c:
http://patchwork.ozlabs.org/patch/122552/
Thanks,
Anatolij
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] dockstar: include headers that were removed from kirkwood.h
2011-10-29 19:41 ` Anatolij Gustschin
@ 2011-10-29 19:54 ` Eric Cooper
0 siblings, 0 replies; 3+ messages in thread
From: Eric Cooper @ 2011-10-29 19:54 UTC (permalink / raw)
To: u-boot
On Sat, Oct 29, 2011 at 09:41:45PM +0200, Anatolij Gustschin wrote:
> There is another similar patch also fixing compiler warning for mvgbe.c:
>
> http://patchwork.ozlabs.org/patch/122552/
Yes, please go ahead and use yours. I'd suggest moving the #includes
in dockstar.c up a few lines, though, so that '#include "dockstar.h"'
is the last one, to be consistent with other board files like
sheevaplug.c etc.
--
Eric Cooper e c c @ c m u . e d u
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-29 19:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-29 19:09 [U-Boot] [PATCH] dockstar: include headers that were removed from kirkwood.h Eric Cooper
2011-10-29 19:41 ` Anatolij Gustschin
2011-10-29 19:54 ` Eric Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox