public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Simon Guinot <simon@sequanux.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: netspace_v2: fix warnings
Date: Sun, 30 Oct 2011 13:40:21 +0100	[thread overview]
Message-ID: <20111030124021.GE13322@kw.sim.vm.gnt> (raw)
In-Reply-To: <1319923879-8783-1-git-send-email-agust@denx.de>

On Sat, Oct 29, 2011 at 11:31:19PM +0200, Anatolij Gustschin wrote:
> Fix compiler warnings when compiling for netspace_v2, netspace_max_v2
> and inetspace_v2:
> 
> netspace_v2.c: In function 'board_early_init_f':
> netspace_v2.c:37: warning: implicit declaration of function 'kw_config_gpio'
> netspace_v2.c: In function 'board_init':
> netspace_v2.c:86: warning: implicit declaration of function 'kw_sdram_bar'

It seems to me this regression has been introduced by:

commit a7efd719f415833a833d6a8e46bcd470a0847ecc
Author: Lei Wen <[leiwen@marvell.com]>
Date:   Tue Oct 18 20:11:42 2011 +0530

    ARM: kirkwood: reduce dependence of including platform file
    
    For files like the drivers/serial/serial.c, it must include the
    platform file, as the CONFIG_SYS_NS16550_COM1 must reference to the
    definition in the platform definition files.
    
    Include the platform definition file in the config file, so that it
    would decouple the dependence for the driver files.
    
    Signed-off-by: Lei Wen <leiwen@marvell.com>

Maybe that more boards are affected.

> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Simon Guinot <simon.guinot@sequanux.org>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
>  board/LaCie/netspace_v2/netspace_v2.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/board/LaCie/netspace_v2/netspace_v2.c b/board/LaCie/netspace_v2/netspace_v2.c
> index 3bb83f3..7c4b15e 100644
> --- a/board/LaCie/netspace_v2/netspace_v2.c
> +++ b/board/LaCie/netspace_v2/netspace_v2.c
> @@ -24,6 +24,7 @@
>  #include <miiphy.h>
>  #include <netdev.h>
>  #include <command.h>
> +#include <asm/arch/cpu.h>
>  #include <asm/arch/kirkwood.h>
>  #include <asm/arch/mpp.h>
>  #include <asm/arch/gpio.h>

Acked-by: Simon Guinot <simon.guinot@sequanux.org>

Thanks for the compilation clean-up.

Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111030/e6aaa9cc/attachment.pgp 

      parent reply	other threads:[~2011-10-30 12:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-29 21:31 [U-Boot] [PATCH] ARM: netspace_v2: fix warnings Anatolij Gustschin
2011-10-29 22:36 ` Marek Vasut
2011-10-30 10:45 ` Albert ARIBAUD
2011-10-30 11:34   ` Anatolij Gustschin
2011-10-30 16:19     ` Albert ARIBAUD
2011-10-30 16:21       ` Anatolij Gustschin
2011-10-30 12:40 ` Simon Guinot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111030124021.GE13322@kw.sim.vm.gnt \
    --to=simon@sequanux.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox