* [U-Boot] PATCH: Add "time" command
@ 2011-10-29 14:57 Peter Barada
2011-10-30 15:13 ` Mike Frysinger
0 siblings, 1 reply; 4+ messages in thread
From: Peter Barada @ 2011-10-29 14:57 UTC (permalink / raw)
To: u-boot
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] PATCH: Add "time" command
2011-10-29 14:57 [U-Boot] PATCH: Add "time" command Peter Barada
@ 2011-10-30 15:13 ` Mike Frysinger
2011-10-30 15:55 ` Wolfgang Denk
0 siblings, 1 reply; 4+ messages in thread
From: Mike Frysinger @ 2011-10-30 15:13 UTC (permalink / raw)
To: u-boot
On Saturday 29 October 2011 10:57:48 Peter Barada wrote:
> Add 'time <cmd> <args>' which executes <cmd> with <args> and shows the
> execution time in seconds. Requires get_timer().
NAK: we already have common/cmd_time.c and CONFIG_CMD_TIME
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111030/3de5c179/attachment.pgp
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] PATCH: Add "time" command
2011-10-30 15:13 ` Mike Frysinger
@ 2011-10-30 15:55 ` Wolfgang Denk
2011-10-30 18:15 ` Mike Frysinger
0 siblings, 1 reply; 4+ messages in thread
From: Wolfgang Denk @ 2011-10-30 15:55 UTC (permalink / raw)
To: u-boot
Dear Mike Frysinger,
In message <201110301113.25446.vapier@gentoo.org> you wrote:
>
> > Add 'time <cmd> <args>' which executes <cmd> with <args> and shows the
> > execution time in seconds. Requires get_timer().
>
> NAK: we already have common/cmd_time.c and CONFIG_CMD_TIME
But common/cmd_time.c is unportable and only available on ARM due so
using a non standard timer API (get_timer_masked() etc.
I wonder if we should swap the implementations.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It would be illogical to kill without reason
-- Spock, "Journey to Babel", stardate 3842.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] PATCH: Add "time" command
2011-10-30 15:55 ` Wolfgang Denk
@ 2011-10-30 18:15 ` Mike Frysinger
0 siblings, 0 replies; 4+ messages in thread
From: Mike Frysinger @ 2011-10-30 18:15 UTC (permalink / raw)
To: u-boot
On Sunday 30 October 2011 11:55:15 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > Add 'time <cmd> <args>' which executes <cmd> with <args> and shows the
> > > execution time in seconds. Requires get_timer().
> >
> > NAK: we already have common/cmd_time.c and CONFIG_CMD_TIME
>
> But common/cmd_time.c is unportable and only available on ARM due so
> using a non standard timer API (get_timer_masked() etc.
i think the idea was to use the more exact API like will be available with
Graeme's proposed rewrite ...
> I wonder if we should swap the implementations.
extending the current code to support non-ARM makes sense, but adding a new
code base like the original patch does not
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111030/6706434c/attachment.pgp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-30 18:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-29 14:57 [U-Boot] PATCH: Add "time" command Peter Barada
2011-10-30 15:13 ` Mike Frysinger
2011-10-30 15:55 ` Wolfgang Denk
2011-10-30 18:15 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox