public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] post/post.c: CodingStyle cleanup
Date: Sun, 30 Oct 2011 21:12:53 +0100	[thread overview]
Message-ID: <201110302112.53699.marek.vasut@gmail.com> (raw)
In-Reply-To: <20111030131005.D051111F9E5D@gemini.denx.de>

> Dear Marek Vasut,
> 
> In message <201110300038.14360.marek.vasut@gmail.com> you wrote:
> > > Signed-off-by: Wolfgang Denk <wd@denx.de>
> > > ---
> > > 
> > >  post/post.c |   59
> > > 
> > > +++++++++++++++++++++++++++-------------------------------- 1 files
> > > changed, 27 insertions(+), 32 deletions(-)
> > 
> > [...]
> > 
> > >  		if (test->cmd) {
> > > 
> > > -			addr = (ulong) (test->cmd) + gd->reloc_off;
> > > +			addr = (ulong)(test->cmd) + gd->reloc_off;
> > > 
> > >  			test->cmd = (char *)addr;
> > >  		
> > >  		}
> > >  		
> > >  		if (test->desc) {
> > > 
> > > -			addr = (ulong) (test->desc) + gd->reloc_off;
> > > +			addr = (ulong)(test->desc) + gd->reloc_off;
> > > 
> > >  			test->desc = (char *)addr;
> > >  		
> > >  		}
> > >  		
> > >  		if (test->test) {
> > > 
> > > -			addr = (ulong) (test->test) + gd->reloc_off;
> > > +			addr = (ulong)(test->test) + gd->reloc_off;
> > > 
> > >  			test->test = (int (*)(int flags)) addr;
> > >  		
> > >  		}
> > >  		
> > >  		if (test->init_f) {
> > > 
> > > -			addr = (ulong) (test->init_f) + gd->reloc_off;
> > > +			addr = (ulong)(test->init_f) + gd->reloc_off;
> > > 
> > >  			test->init_f = (int (*)(void)) addr;
> > >  		
> > >  		}
> > >  		
> > >  		if (test->reloc) {
> > > 
> > > -			addr = (ulong) (test->reloc) + gd->reloc_off;
> > > +			addr = (ulong)(test->reloc) + gd->reloc_off;
> > 
> > The cast here doesn't seem right maybe ? :-(
> 
> Why not?
> 
> BTW:  this is only a CodingStyle cleanup without any changes of the
> logic.
> 
> Best regards,
> 
> Wolfgang Denk

Ok! Add my:

Acked-by: Marek Vasut <marek.vasut@gmail.com>

  reply	other threads:[~2011-10-30 20:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-29 19:42 [U-Boot] [PATCH 1/2] post/post.c: CodingStyle cleanup Wolfgang Denk
2011-10-29 19:42 ` [U-Boot] [PATCH 2/2] post/post.c: fix GCC 4.6 build warnings Wolfgang Denk
2011-11-03 19:44   ` Wolfgang Denk
2011-10-29 22:38 ` [U-Boot] [PATCH 1/2] post/post.c: CodingStyle cleanup Marek Vasut
2011-10-30 13:10   ` Wolfgang Denk
2011-10-30 20:12     ` Marek Vasut [this message]
2011-11-03 19:42 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110302112.53699.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox