From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Sun, 30 Oct 2011 21:12:53 +0100
Subject: [U-Boot] [PATCH 1/2] post/post.c: CodingStyle cleanup
In-Reply-To: <20111030131005.D051111F9E5D@gemini.denx.de>
References: <1319917343-14604-1-git-send-email-wd@denx.de>
	<201110300038.14360.marek.vasut@gmail.com>
	<20111030131005.D051111F9E5D@gemini.denx.de>
Message-ID: <201110302112.53699.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> Dear Marek Vasut,
> 
> In message <201110300038.14360.marek.vasut@gmail.com> you wrote:
> > > Signed-off-by: Wolfgang Denk <wd@denx.de>
> > > ---
> > > 
> > >  post/post.c |   59
> > > 
> > > +++++++++++++++++++++++++++-------------------------------- 1 files
> > > changed, 27 insertions(+), 32 deletions(-)
> > 
> > [...]
> > 
> > >  		if (test->cmd) {
> > > 
> > > -			addr = (ulong) (test->cmd) + gd->reloc_off;
> > > +			addr = (ulong)(test->cmd) + gd->reloc_off;
> > > 
> > >  			test->cmd = (char *)addr;
> > >  		
> > >  		}
> > >  		
> > >  		if (test->desc) {
> > > 
> > > -			addr = (ulong) (test->desc) + gd->reloc_off;
> > > +			addr = (ulong)(test->desc) + gd->reloc_off;
> > > 
> > >  			test->desc = (char *)addr;
> > >  		
> > >  		}
> > >  		
> > >  		if (test->test) {
> > > 
> > > -			addr = (ulong) (test->test) + gd->reloc_off;
> > > +			addr = (ulong)(test->test) + gd->reloc_off;
> > > 
> > >  			test->test = (int (*)(int flags)) addr;
> > >  		
> > >  		}
> > >  		
> > >  		if (test->init_f) {
> > > 
> > > -			addr = (ulong) (test->init_f) + gd->reloc_off;
> > > +			addr = (ulong)(test->init_f) + gd->reloc_off;
> > > 
> > >  			test->init_f = (int (*)(void)) addr;
> > >  		
> > >  		}
> > >  		
> > >  		if (test->reloc) {
> > > 
> > > -			addr = (ulong) (test->reloc) + gd->reloc_off;
> > > +			addr = (ulong)(test->reloc) + gd->reloc_off;
> > 
> > The cast here doesn't seem right maybe ? :-(
> 
> Why not?
> 
> BTW:  this is only a CodingStyle cleanup without any changes of the
> logic.
> 
> Best regards,
> 
> Wolfgang Denk

Ok! Add my:

Acked-by: Marek Vasut <marek.vasut@gmail.com>