From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board
Date: Sun, 30 Oct 2011 21:14:01 +0100 [thread overview]
Message-ID: <201110302114.01489.marek.vasut@gmail.com> (raw)
In-Reply-To: <20111030131230.14FBB11F9E5D@gemini.denx.de>
> Dear Marek Vasut,
>
> In message <201110300047.46696.marek.vasut@gmail.com> you wrote:
> > > /*--------------------------------------------------------------------
> > > ----
> > >
> > > --*/ +#ifndef MACH_TYPE_EB_CPUX9K2
> > > +#define MACH_TYPE_EB_CPUX9K2 1977
> > > +#endif
> > > +/*--------------------------------------------------------------------
> > > ---- --*/ #define CONFIG_SYS_TEXT_BASE 0x00000000
> > >
> > > #define CONFIG_SYS_LOAD_ADDR 0x21000000 /* default load
address */
> >
> > You don't need the ifndef. Cheers
>
> But it doesn;t hurt either. I consider it defensive programming, just
> in case the #defined gets re-added to machtypes.h.
>
> Best regards,
>
> Wolfgang Denk
Sure, but if the machine ID is re-added, we will get a warning in here without
the ifdefs. With the ifdefs, the machine ID might be different here and in the
mach-types file and it might slide unnoticed.
prev parent reply other threads:[~2011-10-30 20:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-29 10:20 [U-Boot] [PATCH] ARM: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board Jens Scharsig
2011-10-29 22:47 ` Marek Vasut
2011-10-30 10:32 ` Albert ARIBAUD
2011-10-31 7:28 ` Jens Scharsig
2011-10-30 13:12 ` Wolfgang Denk
2011-10-30 20:14 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110302114.01489.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox