From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Sun, 30 Oct 2011 21:14:01 +0100
Subject: [U-Boot] [PATCH] ARM: re-introduce the MACH_TYPE_XXXXXX for
	EB_CPUX9K2 board
In-Reply-To: <20111030131230.14FBB11F9E5D@gemini.denx.de>
References: <1319883627-9817-1-git-send-email-js_at_ng@scharsoft.de>
	<201110300047.46696.marek.vasut@gmail.com>
	<20111030131230.14FBB11F9E5D@gemini.denx.de>
Message-ID: <201110302114.01489.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> Dear Marek Vasut,
> 
> In message <201110300047.46696.marek.vasut@gmail.com> you wrote:
> > >  /*--------------------------------------------------------------------
> > >  ----
> > > 
> > > --*/ +#ifndef MACH_TYPE_EB_CPUX9K2
> > > +#define MACH_TYPE_EB_CPUX9K2           1977
> > > +#endif
> > > +/*--------------------------------------------------------------------
> > > ---- --*/ #define CONFIG_SYS_TEXT_BASE 		0x00000000
> > > 
> > >  #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load 
address */
> > 
> > You don't need the ifndef. Cheers
> 
> But it doesn;t hurt either.  I consider it defensive programming, just
> in case the #defined gets re-added to machtypes.h.
> 
> Best regards,
> 
> Wolfgang Denk

Sure, but if the machine ID is re-added, we will get a warning in here without 
the ifdefs. With the ifdefs, the machine ID might be different here and in the 
mach-types file and it might slide unnoticed.