From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 12/18] GCC4.6: Squash warnings in smsc95xx.c
Date: Sun, 30 Oct 2011 21:48:50 +0100 [thread overview]
Message-ID: <201110302148.50367.marek.vasut@gmail.com> (raw)
In-Reply-To: <201110301637.29795.vapier@gentoo.org>
> On Tuesday 25 October 2011 05:39:58 Marek Vasut wrote:
> > --- a/drivers/usb/eth/smsc95xx.c
> > +++ b/drivers/usb/eth/smsc95xx.c
> >
> > - addr_lo = cpu_to_le32(*((u32 *)eth->enetaddr));
> > + addr_lo = cpu_to_le32(*eth->enetaddr);
>
> pretty sure this is wrong. enetaddr is a uchar[], so your code now reads
> only 1 byte instead of 4.
>
> that said, this code also seems to not be endian safe ...
> -mike
It's good anyone actually cares to properly review. Anyway, why does noone
actually care to fix all the damn warnings in their drivers before submitting
them in the first place ?!
next prev parent reply other threads:[~2011-10-30 20:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 9:39 [U-Boot] [PATCH 00/18] CLEANUP: Cleanup of drivers/ directory Marek Vasut
2011-10-25 9:39 ` [U-Boot] [PATCH 01/18] GCC4.6: Squash warning in cfb_console.c Marek Vasut
2011-10-27 21:59 ` Wolfgang Denk
2011-10-25 9:39 ` [U-Boot] [PATCH 02/18] GCC4.6: Squash warning in cfi_flash.c Marek Vasut
2011-10-27 21:59 ` Wolfgang Denk
2011-10-25 9:39 ` [U-Boot] [PATCH 03/18] GCC4.6: Squash warning in jedec_flash.c Marek Vasut
2011-10-27 21:59 ` Wolfgang Denk
2011-10-25 9:39 ` [U-Boot] [PATCH 04/18] GCC4.6: Squash warnings in 4xx_enet.c Marek Vasut
2011-10-27 21:59 ` Wolfgang Denk
2011-10-25 9:39 ` [U-Boot] [PATCH 05/18] GCC4.6: Squash warnings in ahci.c Marek Vasut
2011-10-27 21:59 ` Wolfgang Denk
2011-10-25 9:39 ` [U-Boot] [PATCH 06/18] GCC4.6: Squash warnings in fsl_espi.c Marek Vasut
2011-10-27 21:59 ` Wolfgang Denk
2011-10-25 9:39 ` [U-Boot] [PATCH 07/18] GCC4.6: Squash warnings in fsl_pci_init.c Marek Vasut
2011-10-27 21:59 ` Wolfgang Denk
2011-10-25 9:39 ` [U-Boot] [PATCH 08/18] GCC4.6: Squash warnings in sata_sil3114.c Marek Vasut
2011-10-27 22:00 ` Wolfgang Denk
2011-10-25 9:39 ` [U-Boot] [PATCH 09/18] GCC4.6: Squash warnings in tqm8xx_pcmcia.c Marek Vasut
2011-10-27 22:00 ` Wolfgang Denk
2011-10-25 9:39 ` [U-Boot] [PATCH 10/18] GCC4.6: Squash error in pcmcia/i82365.c Marek Vasut
2011-10-27 22:00 ` Wolfgang Denk
2011-10-25 9:39 ` [U-Boot] [PATCH 11/18] GCC4.6: Fix warnings in pxa_mmc.c Marek Vasut
2011-10-27 22:00 ` Wolfgang Denk
2011-10-25 9:39 ` [U-Boot] [PATCH 12/18] GCC4.6: Squash warnings in smsc95xx.c Marek Vasut
2011-10-27 22:00 ` Wolfgang Denk
2011-10-30 20:37 ` Mike Frysinger
2011-10-30 20:48 ` Marek Vasut [this message]
2011-10-30 22:03 ` Wolfgang Denk
2011-10-30 22:19 ` Marek Vasut
2011-10-30 22:59 ` Mike Frysinger
2011-10-30 23:45 ` Marek Vasut
2011-10-31 0:19 ` Mike Frysinger
2011-10-25 9:39 ` [U-Boot] [PATCH 13/18] GCC4.6: Squash warnings in kirkwood_spi.c Marek Vasut
2011-10-27 22:00 ` Wolfgang Denk
2011-10-25 9:40 ` [U-Boot] [PATCH 14/18] GCC4.6: Squash warnings in lattice.c Marek Vasut
2011-10-27 22:00 ` Wolfgang Denk
2011-10-25 9:40 ` [U-Boot] [PATCH 15/18] GCC4.6: Squash warnings in ks8695eth.c Marek Vasut
2011-10-27 22:00 ` Wolfgang Denk
2011-10-25 9:40 ` [U-Boot] [PATCH 16/18] GCC4.6: Squash warning in bus_vcxk.c Marek Vasut
2011-10-27 22:00 ` Wolfgang Denk
2011-10-25 9:40 ` [U-Boot] [PATCH 17/18] GCC4.6: Squash warnings in fec_mxc.c Marek Vasut
2011-10-27 22:00 ` Wolfgang Denk
2011-10-25 9:40 ` [U-Boot] [PATCH 18/18] GCC4.6: Use debug() instead of debugX() in s3c24xx_nand.c Marek Vasut
2011-10-27 22:01 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110302148.50367.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox