From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Mon, 31 Oct 2011 17:38:32 -0400 Subject: [U-Boot] [PATCH] cmd_bdinfo: simplify local static funcs a bit In-Reply-To: References: <1320022463-26410-1-git-send-email-vapier@gentoo.org> <201110311644.02847.vapier@gentoo.org> Message-ID: <201110311738.33047.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 31 October 2011 16:47:08 Simon Glass wrote: > On Mon, Oct 31, 2011 at 1:44 PM, Mike Frysinger wrote: > > On Monday 31 October 2011 15:11:35 Simon Glass wrote: > >> On Sun, Oct 30, 2011 at 5:54 PM, Mike Frysinger wrote: > >> > If we move the local funcs to the top of the file, and use the > >> > __maybe_unused define, we can drop a lot of ugly ifdef logic and > >> > duplicated prototypes. > >> > > >> > Signed-off-by: Mike Frysinger > >> > >> This is much cleaner - is the correct style to put attribute tags on > >> the previous line? > > > > when responding to add your own, there isn't any real protocol. just > > normal e-mail etiquette (no top posting/etc...). patchwork/humans will > > do the right thing when manually updating the changelog. > > Actually I meant the __maybe_unused tag before the function name. ah. i'm not sure there is a hard rule here. i did that because one line would make the func def too long to fit. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20111031/0b6ba257/attachment.pgp