From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: mv_sdhci: Fix host version read for Armada100
Date: Tue, 1 Nov 2011 12:49:18 +0100 [thread overview]
Message-ID: <201111011249.18559.marek.vasut@gmail.com> (raw)
In-Reply-To: <1320140391-13427-1-git-send-email-ajay.bhargav@einfochips.com>
> sdhci_readw does not work for host version read in Armada100 series
> SoCs. This patch fix this issue by making a sdhci_readl call to get host
> version.
>
> Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
> ---
> drivers/mmc/mv_sdhci.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c
> index f92caeb..c7fd287 100644
> --- a/drivers/mmc/mv_sdhci.c
> +++ b/drivers/mmc/mv_sdhci.c
> @@ -30,6 +30,7 @@ static inline void mv_sdhci_writeb(struct sdhci_host
> *host, u8 val, int reg) #endif /* CONFIG_MMC_SDHCI_IO_ACCESSORS */
>
> static char *MVSDH_NAME = "mv_sdh";
> +
> int mv_sdh_init(u32 regbase, u32 max_clk, u32 min_clk, u32 quirks)
> {
> struct sdhci_host *host = NULL;
> @@ -48,7 +49,12 @@ int mv_sdh_init(u32 regbase, u32 max_clk, u32 min_clk,
> u32 quirks) mv_ops.write_b = mv_sdhci_writeb;
> host->ops = &mv_ops;
> #endif
> +#ifdef CONFIG_ARMADA100
> + /* SDHCI host version read workaround for Armada100 series */
> + host->version = sdhci_readl(host, SDHCI_HOST_VERSION - 2) >> 16;
> +#else
> host->version = sdhci_readw(host, SDHCI_HOST_VERSION);
> +#endif
> add_sdhci(host, max_clk, min_clk);
> return 0;
> }
Basically armada100 can't do 16bit access to that register. Ok, but why does it
work for other registers? Also, can you make this a config option like
CONFIG_SDHCI_REG32_QUIRK (invent some better name ;-) ).
Cheers
next prev parent reply other threads:[~2011-11-01 11:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 9:39 [U-Boot] [PATCH] mmc: mv_sdhci: Fix host version read for Armada100 Ajay Bhargav
2011-11-01 11:49 ` Marek Vasut [this message]
2011-11-01 14:13 ` Lei Wen
2011-11-02 5:38 ` Ajay Bhargav
[not found] <868712092.287809.1320150229717.JavaMail.root@ahm.einfochips.com>
2011-11-01 12:30 ` Ajay Bhargav
2011-11-01 14:57 ` Marek Vasut
[not found] <1050282894.290152.1320212635906.JavaMail.root@ahm.einfochips.com>
2011-11-02 5:46 ` Ajay Bhargav
2011-11-02 10:25 ` Marek Vasut
2011-11-02 12:09 ` Prafulla Wadaskar
2011-11-02 14:28 ` Marek Vasut
2011-11-03 7:41 ` Prafulla Wadaskar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111011249.18559.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox