From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] mvgbe: fix network device indices
Date: Thu, 3 Nov 2011 19:11:50 -0400 [thread overview]
Message-ID: <201111031911.51227.vapier@gentoo.org> (raw)
In-Reply-To: <201111040002.26570.michael@walle.cc>
On Thursday 03 November 2011 19:02:26 Michael Walle wrote:
> Am Donnerstag 03 November 2011, 19:10:57 schrieb Mike Frysinger:
> > On Thursday 27 October 2011 17:31:36 Michael Walle wrote:
> > > --- a/drivers/net/mvgbe.c
> > > +++ b/drivers/net/mvgbe.c
> > >
> > > + /* Extract the MAC address from the environment */
> > > + while (!eth_getenv_enetaddr_by_index("eth", dev->index,
> > > + dev->enetaddr)) {
> > >
> > > /* Generate Private MAC addr if not set */
> > > dev->enetaddr[0] = 0x02;
> > > dev->enetaddr[1] = 0x50;
> >
> > this is wrong. net drivers should not be touching the env at all.
> > please fix your driver to not do that first.
>
> i guess this whole mac randomization/generation code belongs to board
> specific files.
correct
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111103/dbdf1c96/attachment.pgp
next prev parent reply other threads:[~2011-11-03 23:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 22:23 [U-Boot] [PATCH] mvgbe: fix network device indices Michael Walle
2011-10-07 8:26 ` Prafulla Wadaskar
2011-10-07 10:48 ` Michael Walle
2011-10-16 18:28 ` Michael Walle
2011-10-07 17:16 ` Mike Frysinger
2011-10-21 8:09 ` Prafulla Wadaskar
2011-10-25 21:10 ` Michael Walle
2011-10-27 9:12 ` Prafulla Wadaskar
2011-10-27 10:22 ` Michael Walle
2011-10-27 21:31 ` [U-Boot] [PATCH 0/2] improve ethernet device index handling Michael Walle
2011-10-27 21:31 ` [U-Boot] [PATCH 1/2] net: introduce per device index Michael Walle
2011-10-27 21:36 ` Michael Walle
2011-11-03 11:23 ` Michael Walle
2011-11-03 11:39 ` Prafulla Wadaskar
2011-11-03 17:58 ` Wolfgang Denk
2011-11-03 18:09 ` Mike Frysinger
2011-10-27 21:31 ` [U-Boot] [PATCH 2/2] mvgbe: fix network device indices Michael Walle
2011-11-03 18:10 ` Mike Frysinger
2011-11-03 23:02 ` Michael Walle
2011-11-03 23:11 ` Mike Frysinger [this message]
2011-11-04 6:29 ` Prafulla Wadaskar
2011-11-04 23:06 ` Mike Frysinger
2011-11-05 9:53 ` Albert ARIBAUD
2011-11-05 13:21 ` Wolfgang Denk
2011-11-05 14:34 ` Albert ARIBAUD
2011-11-05 15:06 ` Wolfgang Denk
2011-11-08 7:44 ` Prafulla Wadaskar
2011-11-08 7:32 ` Prafulla Wadaskar
2011-11-08 13:56 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111031911.51227.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox