From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 3 Nov 2011 22:52:18 +0100 Subject: [U-Boot] [PATCH 4/4 V3] PXA: Adapt Voipac PXA270 to OneNAND SPL In-Reply-To: <4EB2D8D2.7040603@freescale.com> References: <1320188094-6654-1-git-send-email-marek.vasut@gmail.com> <1320285411-23842-1-git-send-email-marek.vasut@gmail.com> <4EB2D8D2.7040603@freescale.com> Message-ID: <201111032252.18260.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > On 11/02/2011 08:56 PM, Marek Vasut wrote: > > + onenand_spl_load_image(CONFIG_SPL_ONENAND_LOAD_ADDR, > > + CONFIG_SPL_ONENAND_LOAD_SIZE, > > + (void *)CONFIG_SYS_TEXT_BASE); > > If we make it "nand_spl_load_image", and make the #defines conform, we > can have the same code call the function for nand and onenand. I don't > see any reason why onenand is a completely different subsystem in > general, rather than just another NAND driver. The NAND subsystem's > driver interface is lower level than it should be, but that affects > other NAND controllers as well (such as fsl_elbc). > > Switching to the generic nand_boot() in > http://patchwork.ozlabs.org/patch/123219/ would get you the ability to > load the environment during the SPL. > > -Scott I don't think I understand. Why do you want to mix onenand and nand ? Also, will your approach still allow me to squeeze the important code into the first 1kb for the initial copying of SPL?