From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Walle <michael@walle.cc>
Date: Fri, 4 Nov 2011 00:02:26 +0100
Subject: [U-Boot] [PATCH 2/2] mvgbe: fix network device indices
In-Reply-To: <201111031410.58442.vapier@gentoo.org>
References: <201110252310.30372.michael@walle.cc>
	<1319751096-24404-3-git-send-email-michael@walle.cc>
	<201111031410.58442.vapier@gentoo.org>
Message-ID: <201111040002.26570.michael@walle.cc>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Am Donnerstag 03 November 2011, 19:10:57 schrieb Mike Frysinger:
> On Thursday 27 October 2011 17:31:36 Michael Walle wrote:
> > --- a/drivers/net/mvgbe.c
> > +++ b/drivers/net/mvgbe.c
> > 
> > +		/* Extract the MAC address from the environment */
> > +		while (!eth_getenv_enetaddr_by_index("eth", dev->index,
> > +					dev->enetaddr)) {
> > 
> >  			/* Generate Private MAC addr if not set */
> >  			dev->enetaddr[0] = 0x02;
> >  			dev->enetaddr[1] = 0x50;
> 
> this is wrong.  net drivers should not be touching the env at all.  please
> fix your driver to not do that first.

i guess this whole mac randomization/generation code belongs to board specific 
files.

-- 
Michael