From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] [x86] Add a basic implementation for a coreboot board
Date: Fri, 4 Nov 2011 18:24:23 -0400 [thread overview]
Message-ID: <201111041824.24804.vapier@gentoo.org> (raw)
In-Reply-To: <1320443602-2677-1-git-send-email-gabeblack@chromium.org>
i'm not terribly familiar with what it takes to make an x86 board, but i don't
see anything jumping out of this patch.
i would note however that you should merge the boards.cfg update into this
patch. merging one or the other doesn't make much sense, and there's no
reason to keep them split.
> +void setup_pcat_compatibility()
should be "(void)"
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111104/8327e21c/attachment.pgp
next prev parent reply other threads:[~2011-11-04 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 21:53 [U-Boot] [PATCH v2] [x86] Add a basic implementation for a coreboot board Gabe Black
2011-11-04 22:24 ` Mike Frysinger [this message]
2011-11-04 22:33 ` Gabe Black
2011-11-04 22:39 ` Mike Frysinger
2011-11-05 1:59 ` Graeme Russ
2011-11-05 0:12 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111041824.24804.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox