From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/3] Add limits.h to hold basic limits
Date: Fri, 4 Nov 2011 19:09:00 -0400 [thread overview]
Message-ID: <201111041909.01113.vapier@gentoo.org> (raw)
In-Reply-To: <CAPnjgZ0vqTa8VHBRWHTskPiMdxPckD6NoHoJJ+Nk-2fJyM3fSA@mail.gmail.com>
On Friday 04 November 2011 01:14:08 Simon Glass wrote:
> On Thu, Nov 3, 2011 at 7:33 PM, Mike Frysinger wrote:
> > On Monday 10 October 2011 15:22:29 Simon Glass wrote:
> >> This brings a basic limits.h implementation into U-Boot.
> >
> > sorry to jump in so late, but i think this was the correct way to go.
> > copying & pasting the same defines throughout the tree doesn't make
> > much sense. this would also make it easier to grab changes from Linux
> > since they're the same.
>
> Well Albert was pretty keen on leaving this out. Next time we need
> INT_MAX somewhere, or see someone defining it in a patch, we can think
> about adding limits.h.
his complaint was that there was one consumer. we now have two. and in both
cases, it's because we imported code from Linux.
i would take the position that even if there is just one consumer (ubifs in
this case), we should be importing this. although it might make more sense to
have this in linux/limits.h. only downside there is that the upstream Linux
code (oddly) places these in linux/kernel.h instead of linux/limits.h. but i
think i can live with that idiosyncrasy.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111104/9d5bdc43/attachment.pgp
next prev parent reply other threads:[~2011-11-04 23:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 19:22 [U-Boot] [PATCH v2 0/3] Buffer overruns in printf Simon Glass
2011-10-10 19:22 ` [U-Boot] [PATCH v2 1/3] Add limits.h to hold basic limits Simon Glass
2011-10-21 19:54 ` Albert ARIBAUD
2011-10-21 20:19 ` Simon Glass
2011-10-21 21:00 ` Albert ARIBAUD
2011-10-21 21:12 ` Simon Glass
2011-10-21 21:47 ` Albert ARIBAUD
2011-10-21 22:02 ` Simon Glass
2011-10-21 22:39 ` Albert ARIBAUD
2011-10-22 4:58 ` Simon Glass
2011-10-25 23:43 ` Simon Glass
2011-11-04 2:33 ` Mike Frysinger
2011-11-04 5:14 ` Simon Glass
2011-11-04 23:09 ` Mike Frysinger [this message]
2011-11-05 0:24 ` Simon Glass
2011-10-10 19:22 ` [U-Boot] [PATCH v2 2/3] Add safe vsnprintf and snprintf library functions Simon Glass
2011-10-10 19:22 ` [U-Boot] [PATCH v2 3/3] Make printf and vprintf safe from buffer overruns Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111041909.01113.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox