From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 6 Nov 2011 16:16:47 +0100 Subject: [U-Boot] [PATCH] NAND: Let NAND_NO_SUBPAGE_WRITE through In-Reply-To: <4EB69FC0.2060500@denx.de> References: <1320459844-18243-1-git-send-email-marek.vasut@gmail.com> <201111061343.45155.marek.vasut@gmail.com> <4EB69FC0.2060500@denx.de> Message-ID: <201111061616.47432.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > On 11/06/2011 01:43 PM, Marek Vasut wrote: > > Yes sure, but the controller driver sets it as a chip option as there's > > no "controller" option field and I don't want to introduce new > > definition consuming one bit in the top half of chip option. > > Let's see how evolve the discussion - allowing to mix chip and > controller options was Exactly, I consider this patch more as a workaround, so figuring out a proper solution would be awesome. Though I'm quite sure there is a bug in the MTD layer. > > > No, the controller must set NAND_NO_SUBPAGE_WRITE as a chip option in its > > driver to force it so it should work for both cases. > > As far as I remember (not very well, I admit..), the only way for the > driver to set them was in the board_nand_init(), but these options are > overwritten when the flash is detected, making NAND_NO_SUBPAGE_WRITE > worthless. Am I wrong ? > This is what this patch works around ;-)