public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v0 6/7] x86: Misc PCI touchups
Date: Mon, 07 Nov 2011 22:57:44 +0100	[thread overview]
Message-ID: <20111107215744.BFD38189301B@gemini.denx.de> (raw)
In-Reply-To: <1320459711-20257-7-git-send-email-graeme.russ@gmail.com>

Dear Graeme Russ,

In message <1320459711-20257-7-git-send-email-graeme.russ@gmail.com> you wrote:
> 

This is not checkpatch clean:

ERROR: "foo* bar" should be "foo *bar"
#123: FILE: arch/x86/include/asm/pci.h:29:
+void pci_setup_type1(struct pci_controller* hose);

WARNING: line over 80 characters
#136: FILE: arch/x86/lib/pci_type1.c:54:
+/* bus mapping constants (used for PCI core initialization) */
/* bus mapping constants */

ERROR: "foo* bar" should be "foo *bar"
#140: FILE: arch/x86/lib/pci_type1.c:58:
+void pci_setup_type1(struct pci_controller* hose)

total: 2 errors, 1 warnings, 54 lines checked


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The sooner our happiness together begins, the longer it will last.
	-- Miramanee, "The Paradise Syndrome", stardate 4842.6

  reply	other threads:[~2011-11-07 21:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-05  2:21 [U-Boot] [PATCH v0 0/7] Various x86 fixups Graeme Russ
2011-11-05  2:21 ` [U-Boot] [PATCH v0 1/7] x86: Punt cold- and warm-boot flags Graeme Russ
2011-11-05 17:03   ` Mike Frysinger
2011-11-08 12:33   ` [U-Boot] [PATCH v2 06/12] " Graeme Russ
2011-11-08 13:51     ` Mike Frysinger
2011-11-12 10:07     ` Graeme Russ
2011-11-05  2:21 ` [U-Boot] [PATCH v0 2/7] sc520: Create arch asm-offsets Graeme Russ
2011-11-08 12:33   ` [U-Boot] [PATCH v2 07/12] " Graeme Russ
2011-11-12 10:08     ` Graeme Russ
2011-11-05  2:21 ` [U-Boot] [PATCH v0 3/7] x86: Add multiboot header Graeme Russ
2011-11-07 21:51   ` Wolfgang Denk
2011-11-08 12:33   ` [U-Boot] [PATCH v2 08/12] " Graeme Russ
2011-11-12 10:08     ` Graeme Russ
2011-11-05  2:21 ` [U-Boot] [PATCH v0 4/7] x86: Provide more configuration granularity Graeme Russ
2011-11-07 21:55   ` Wolfgang Denk
2011-11-07 21:59   ` Wolfgang Denk
2011-11-08 12:33   ` [U-Boot] [PATCH v2 09/12] " Graeme Russ
2011-11-12 10:11     ` Graeme Russ
2011-11-05  2:21 ` [U-Boot] [PATCH v0 5/7] x86: Ensure IDT and GDT remain 16-byte aligned post relocation Graeme Russ
2011-11-08 12:33   ` [U-Boot] [PATCH v2 10/12] " Graeme Russ
2011-11-12 10:12     ` Graeme Russ
2011-11-05  2:21 ` [U-Boot] [PATCH v0 6/7] x86: Misc PCI touchups Graeme Russ
2011-11-07 21:57   ` Wolfgang Denk [this message]
2011-11-08 12:33   ` [U-Boot] [PATCH v2 11/12] " Graeme Russ
2011-11-12 10:12     ` Graeme Russ
2011-11-05  2:21 ` [U-Boot] [PATCH v0 7/7] x86: Misc cleanups Graeme Russ
2011-11-08 12:33   ` [U-Boot] [PATCH v2 12/12] " Graeme Russ
2011-11-12 10:13     ` Graeme Russ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111107215744.BFD38189301B@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox