From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [fdt] Fix constness of the fdt void pointer in fdt_getprop_u32_default
Date: Tue, 8 Nov 2011 08:47:42 -0500 [thread overview]
Message-ID: <201111080847.43269.vapier@gentoo.org> (raw)
In-Reply-To: <1320743385-31451-1-git-send-email-gabeblack@chromium.org>
+fdt maintainer
On Tuesday 08 November 2011 04:09:44 Gabe Black wrote:
> The function fdt_getprop_u32_default doesn't modify the fdt, so it can use
> a const void * for its fdt argument.
>
> Signed-off-by: Gabe Black <gabeblack@chromium.org>
> ---
> common/fdt_support.c | 4 ++--
> include/fdt_support.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/common/fdt_support.c b/common/fdt_support.c
> index bdda64d..bd3a014 100644
> --- a/common/fdt_support.c
> +++ b/common/fdt_support.c
> @@ -49,8 +49,8 @@ DECLARE_GLOBAL_DATA_PTR;
> * Convenience function to find a node and return it's property or a
> * default value if it doesn't exist.
> */
> -u32 fdt_getprop_u32_default(void *fdt, const char *path, const char *prop,
> - const u32 dflt)
> +u32 fdt_getprop_u32_default(const void *fdt, const char *path,
> + const char *prop, const u32 dflt)
> {
> const u32 *val;
> int off;
> diff --git a/include/fdt_support.h b/include/fdt_support.h
> index c7b4605..cef3c65 100644
> --- a/include/fdt_support.h
> +++ b/include/fdt_support.h
> @@ -28,8 +28,8 @@
>
> #include <fdt.h>
>
> -u32 fdt_getprop_u32_default(void *fdt, const char *path, const char *prop,
> - const u32 dflt);
> +u32 fdt_getprop_u32_default(const void *fdt, const char *path,
> + const char *prop, const u32 dflt);
> int fdt_chosen(void *fdt, int force);
> int fdt_initrd(void *fdt, ulong initrd_start, ulong initrd_end, int
> force); void do_fixup_by_path(void *fdt, const char *path, const char
> *prop,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111108/e19d79cf/attachment.pgp
next prev parent reply other threads:[~2011-11-08 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 9:09 [U-Boot] [PATCH] [fdt] Fix constness of the fdt void pointer in fdt_getprop_u32_default Gabe Black
2011-11-08 13:47 ` Mike Frysinger [this message]
2011-11-13 2:07 ` Gabe Black
2011-11-13 17:05 ` Jerry Van Baren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111080847.43269.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox