From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 11/13] drivers/video/ct69000.c: Fix GC 4.6 build warning
Date: Thu, 10 Nov 2011 11:21:37 -0500 [thread overview]
Message-ID: <201111101121.38318.vapier@gentoo.org> (raw)
In-Reply-To: <20111110054354.17691189301C@gemini.denx.de>
On Thursday 10 November 2011 00:43:54 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > #undef VGA_DEBUG
> > > #undef VGA_DUMP_REG
> > > #ifdef VGA_DEBUG
> > >
> > > -#define PRINTF(fmt,args...) printf (fmt ,##args)
> > > +#undef _DEBUG
> > > +#define _DEBUG 1
> > >
> > > #else
> > >
> > > -#define PRINTF(fmt,args...)
> > > +#undef _DEBUG
> > > +#define _DEBUG 0
> > >
> > > #endif
> >
> > so do you still need this ? since you've converted to debug(), looks
> > like this logic can all go away.
>
> It's needed if I want to keep the original behaviour regarding
> VGA_DEBUG and VGA_DUMP_REG which were independent before.
ok, i see that now. i wonder if we need that though. i don't think there's
any real difference between doing "#define DEBUG" and "#define VGA_DEBUG".
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111110/7d3ad6cf/attachment.pgp
next prev parent reply other threads:[~2011-11-10 16:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 19:28 [U-Boot] [PATCH 01/13] drivers/block/sym53c8xx.c: Fix GCC 4.6 build warning Wolfgang Denk
2011-11-09 19:28 ` [U-Boot] [PATCH 02/13] board/evb64260/i2c.c: Coding Style cleanup Wolfgang Denk
2011-11-10 6:32 ` Heiko Schocher
2011-11-16 20:03 ` Wolfgang Denk
2011-11-16 20:03 ` Wolfgang Denk
2011-11-09 19:28 ` [U-Boot] [PATCH 03/13] board/evb64260/i2c.c: Fix GCC 4.6 build warnings Wolfgang Denk
2011-11-10 6:33 ` Heiko Schocher
2011-11-16 20:03 ` Wolfgang Denk
2011-11-09 19:28 ` [U-Boot] [PATCH 04/13] board/evb64260/evb64260.c: Fix GC 4.6 build warning Wolfgang Denk
2011-11-16 20:03 ` Wolfgang Denk
2011-11-09 19:28 ` [U-Boot] [PATCH 05/13] board/evb64260/eth.c: Fix GCC " Wolfgang Denk
2011-11-16 20:04 ` Wolfgang Denk
2011-11-09 19:28 ` [U-Boot] [PATCH 06/13] board/evb64260/sdram_init.c: Fix GCC 4.6 build warnings Wolfgang Denk
2011-11-16 20:04 ` Wolfgang Denk
2011-11-09 19:29 ` [U-Boot] [PATCH 07/13] board/evb64260/zuma_pbb_mbox.c: CodingStyle cleanup Wolfgang Denk
2011-11-16 20:04 ` Wolfgang Denk
2011-11-09 19:29 ` [U-Boot] [PATCH 08/13] board/evb64260/zuma_pbb_mbox.c: Fix GCC 4.6 build warnings Wolfgang Denk
2011-11-16 20:04 ` Wolfgang Denk
2011-11-09 19:29 ` [U-Boot] [PATCH 09/13] common/cmd_fdc.c: " Wolfgang Denk
2011-11-16 20:04 ` Wolfgang Denk
2011-11-09 19:29 ` [U-Boot] [PATCH 10/13] common/cmd_universe.c: Fix GCC 4.6 build warning Wolfgang Denk
2011-11-16 20:04 ` Wolfgang Denk
2011-11-09 19:29 ` [U-Boot] [PATCH 11/13] drivers/video/ct69000.c: Fix GC " Wolfgang Denk
2011-11-09 20:44 ` Mike Frysinger
2011-11-10 5:43 ` Wolfgang Denk
2011-11-10 16:21 ` Mike Frysinger [this message]
2011-11-10 19:07 ` Wolfgang Denk
2011-11-10 20:37 ` Anatolij Gustschin
2011-11-16 20:05 ` Wolfgang Denk
2011-11-09 19:29 ` [U-Boot] [PATCH 12/13] board/esd/cpci750/cpci750.c: Fix error handling Wolfgang Denk
2011-11-16 20:05 ` Wolfgang Denk
2011-11-09 19:29 ` [U-Boot] [PATCH 13/13] board/esd/cpci750/sdram_init.c: Fix GCC 4.6 build warnings Wolfgang Denk
2011-11-09 20:45 ` Mike Frysinger
2011-11-09 21:33 ` Reinhard.Arlt at t-online.de
2011-11-16 20:11 ` Wolfgang Denk
2011-11-16 20:12 ` Wolfgang Denk
2011-11-16 20:01 ` [U-Boot] [PATCH 01/13] drivers/block/sym53c8xx.c: Fix GCC 4.6 build warning Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111101121.38318.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox