From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Thu, 10 Nov 2011 11:21:37 -0500 Subject: [U-Boot] [PATCH 11/13] drivers/video/ct69000.c: Fix GC 4.6 build warning In-Reply-To: <20111110054354.17691189301C@gemini.denx.de> References: <1320866946-28235-1-git-send-email-wd@denx.de> <201111091544.17111.vapier@gentoo.org> <20111110054354.17691189301C@gemini.denx.de> Message-ID: <201111101121.38318.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 10 November 2011 00:43:54 Wolfgang Denk wrote: > Mike Frysinger wrote: > > > #undef VGA_DEBUG > > > #undef VGA_DUMP_REG > > > #ifdef VGA_DEBUG > > > > > > -#define PRINTF(fmt,args...) printf (fmt ,##args) > > > +#undef _DEBUG > > > +#define _DEBUG 1 > > > > > > #else > > > > > > -#define PRINTF(fmt,args...) > > > +#undef _DEBUG > > > +#define _DEBUG 0 > > > > > > #endif > > > > so do you still need this ? since you've converted to debug(), looks > > like this logic can all go away. > > It's needed if I want to keep the original behaviour regarding > VGA_DEBUG and VGA_DUMP_REG which were independent before. ok, i see that now. i wonder if we need that though. i don't think there's any real difference between doing "#define DEBUG" and "#define VGA_DEBUG". -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20111110/7d3ad6cf/attachment.pgp