From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] x86: Do no use reparm as it break libgcc linkage
Date: Thu, 10 Nov 2011 12:15:32 -0500 [thread overview]
Message-ID: <201111101215.33554.vapier@gentoo.org> (raw)
In-Reply-To: <CALButCK28MOv9PTAZkuGkHRavtPVYOzSS8yn6_K-Z7igkmEJbA@mail.gmail.com>
On Wednesday 09 November 2011 23:22:34 Graeme Russ wrote:
> On Thu, Nov 10, 2011 at 3:13 PM, Mike Frysinger wrote:
> > i was referring also to throwing away -mregparm=3 ...
>
> Yes, it does effect the code - It makes it ABI compliant like everyone
> else (except ARM) :) I expect a code size increase (have not measured
> it yet)
ABI compliance only matters at the boundaries. since u-boot is largely self-
contained, we shouldn't be afraid to break internal ABI.
> As I've stated, I really do not want arbitrary wrapper functions where
> it is not obvious that they need to be updated if new code uses
> previously unused (and unwrapped) libgcc functions (in particular if
> there are new libgcc functions in the future which we can't wrap
> todday anyway)
>
> Option a) is to remove regparm=3
> Option b) is to use private libgcc
> Option c) is to use wrappers
>
> If this patch works, I'll look at the code impact and we can discuss
> which option we take :)
for the record, i'm not against a private libgcc. it just seems to me that
the wrapper approach proposed by Gabe has the best pro/con ratio.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111110/9683c94d/attachment.pgp
next prev parent reply other threads:[~2011-11-10 17:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 9:27 [U-Boot] [PATCH] [x86] Wrap small helper functions from libgcc to avoid an ABI mismatch Gabe Black
2011-11-08 13:33 ` Mike Frysinger
2011-11-08 22:27 ` Gabe Black
2011-11-08 22:34 ` [U-Boot] [PATCH v2] x86: " Gabe Black
2011-11-08 23:14 ` Graeme Russ
2011-11-09 4:49 ` Mike Frysinger
2011-11-09 3:57 ` Graeme Russ
2011-11-09 5:34 ` Mike Frysinger
2011-11-17 9:01 ` [U-Boot] [PATCH v3] " Gabe Black
2011-11-17 9:13 ` Gabe Black
2011-11-30 11:03 ` Graeme Russ
2011-11-09 3:05 ` [U-Boot] [PATCH v2] " Graeme Russ
2011-11-09 10:32 ` [U-Boot] [RFC] x86: Do no use reparm as it break libgcc linkage Graeme Russ
2011-11-09 17:12 ` Mike Frysinger
2011-11-09 21:42 ` Graeme Russ
2011-11-10 4:13 ` Mike Frysinger
2011-11-10 4:22 ` Graeme Russ
2011-11-10 5:10 ` Graeme Russ
2011-11-10 17:15 ` Mike Frysinger [this message]
2011-11-10 22:53 ` Graeme Russ
2011-11-11 0:23 ` Mike Frysinger
2011-11-11 1:23 ` Graeme Russ
2011-11-11 1:40 ` Mike Frysinger
2011-11-11 1:51 ` Graeme Russ
2011-11-11 1:55 ` Mike Frysinger
2011-11-11 1:59 ` Graeme Russ
2011-11-11 2:10 ` Gabe Black
2011-11-11 2:22 ` Graeme Russ
2011-11-11 2:41 ` Gabe Black
2011-11-11 4:49 ` Graeme Russ
2011-11-11 5:04 ` Mike Frysinger
2011-11-11 5:16 ` Graeme Russ
2011-11-11 16:24 ` Mike Frysinger
2011-11-11 2:44 ` Mike Frysinger
2011-11-11 19:59 ` Scott Wood
2011-11-16 23:00 ` Graeme Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111101215.33554.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox