From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Guinot Date: Thu, 10 Nov 2011 15:21:53 +0100 Subject: [U-Boot] [PATCH] mvgbe: remove setting of ethaddr within the driver In-Reply-To: <20111110120159.997C113BE0E2@gemini.denx.de> References: <1320703689-4879-1-git-send-email-michael@walle.cc> <201111082330.40253.michael@walle.cc> <20111108225256.657A5189301F@gemini.denx.de> <201111090026.09460.michael@walle.cc> <0b31372341432a1daa65fa2aa3c18b35.squirrel@ssl.serverraum.org> <20111109192722.D2BDE13BE0E2@gemini.denx.de> <48935aa530a6457b76b9915a1fe7faf9.squirrel@ssl.serverraum.org> <20111110110608.GB29864@kw.sim.vm.gnt> <20111110120159.997C113BE0E2@gemini.denx.de> Message-ID: <20111110142152.GC29864@kw.sim.vm.gnt> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, On Thu, Nov 10, 2011 at 01:01:59PM +0100, Wolfgang Denk wrote: > Dear Simon Guinot, > > In message <20111110110608.GB29864@kw.sim.vm.gnt> you wrote: > > > > > > Let's remove this broken code. > > > > > > This is exactly part of this patch ([PATCH] mvgbe: remove setting of > > > ethaddr within the driver). This part, while ACK'ed by Mike, was NAK'ed by > > > Prafulla. > > > > As some boards are relying on this broken code, maybe you should provide > > an alternative ? I could be wrong, but it seems to me that just removing > > the code is not enough. > > Which exact boards are these? And how exactly are these relying on the > broken code? I can't list this boards exactly. For sure, I can say that the LaCie boards (netspace_v2 and cie) are concerned. For this boards a random MAC address is used and the computation is performed by the driver mvgbe. If this code is simply removed, the network initialization for this boards will break. I suspect a lot of Marvell boards from being in the same case. Regards, Simon -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: Digital signature Url : http://lists.denx.de/pipermail/u-boot/attachments/20111110/49719d4e/attachment.pgp