From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Guinot Date: Thu, 10 Nov 2011 18:54:29 +0100 Subject: [U-Boot] [PATCH] mvgbe: remove setting of ethaddr within the driver In-Reply-To: <201111101209.06596.vapier@gentoo.org> References: <1320703689-4879-1-git-send-email-michael@walle.cc> <20111110120159.997C113BE0E2@gemini.denx.de> <20111110142152.GC29864@kw.sim.vm.gnt> <201111101209.06596.vapier@gentoo.org> Message-ID: <20111110175429.GD29864@kw.sim.vm.gnt> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Nov 10, 2011 at 12:09:04PM -0500, Mike Frysinger wrote: > On Thursday 10 November 2011 09:21:53 Simon Guinot wrote: > > On Thu, Nov 10, 2011 at 01:01:59PM +0100, Wolfgang Denk wrote: > > > Simon Guinot wrote: > > > > > > Let's remove this broken code. > > > > > > > > > > This is exactly part of this patch ([PATCH] mvgbe: remove setting of > > > > > ethaddr within the driver). This part, while ACK'ed by Mike, was > > > > > NAK'ed by Prafulla. > > > > > > > > As some boards are relying on this broken code, maybe you should > > > > provide an alternative ? I could be wrong, but it seems to me that > > > > just removing the code is not enough. > > > > > > Which exact boards are these? And how exactly are these relying on the > > > broken code? > > > > I can't list this boards exactly. For sure, I can say that the > > LaCie boards (netspace_v2 and cie) are concerned. > > > > For this boards a random MAC address is used and the computation is > > performed by the driver mvgbe. If this code is simply removed, the > > network initialization for this boards will break. > > it will be broken until you set "ethaddr" in the env right ? i think that's > currently the expected behavior ... Yes it is right. I guess if someone is able to write U-Boot into a flash, he is also able to set the environement variable "ethaddr". An extra operation would be needed to setup U-Boot, but clearly it is not a problem. Simon -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: Digital signature Url : http://lists.denx.de/pipermail/u-boot/attachments/20111110/8b0b2ce0/attachment.pgp